Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneccessary/dead code #347

Merged
merged 3 commits into from
Jun 28, 2023
Merged

Remove unneccessary/dead code #347

merged 3 commits into from
Jun 28, 2023

Commits on Jun 20, 2023

  1. CLN: Remove unneccessary guard code around scikit-learn<1.0 

    We no longer allow scikit-learn<1.0, so we can remove compatibility.  Lots of
wet code.
    @Jacob-Stevens-Haas
    Jacob-Stevens-Haas committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    2af92e7 View commit details
    Browse the repository at this point in the history

  2. CLN: Remove unneccessary parameters from model.fit() 

    Three of these parameters do nothing.
"quiet" is unneccessary - user code should silence.
    @Jacob-Stevens-Haas
    Jacob-Stevens-Haas committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    4c334d5 View commit details
    Browse the repository at this point in the history

  3. CLN: Refactor example 1 to testable format 

    Not tested by default from command line, but explicitly enabled in CI
Removed papermill from CI
    @Jacob-Stevens-Haas
    Jacob-Stevens-Haas committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    48d076f View commit details
    Browse the repository at this point in the history