Remove old JDK backwards compatibility classes #3976
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mszabo-wikia <[email protected]>
Signed-off-by: mszabo-wikia <[email protected]>
mszabo-wikia
changed the title
|
Not sure if the test failure is related—it passed on the first commit as well as on OpenJDK 8. |
|
While you are right that the jdk 8 is minimum and we can remove some older collection classes, we definitely cannot remove public classes/method. |
|
Also, I assume we will have some use of the JdkVersion class, in trasition to jdk 9, where we will get rid of the usage of Unsafe class. |
|
I incline to keep the factory methods even when they return directly the new instance of a single class. |
|
@jansupol thanks! I'll prepare a new PR that avoids breaking BC & extend |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ConcurrentHashMapV8class is simply the implementation ofjava.util.concurrent.ConcurrentHashMap, as found in Java 8 and above. It seems it was added to the source to allow older JDK versions to take advantage of its more efficient implementation. However, since version 2.26, Jersey only supports Java 8 and above, therefore this class should no longer be needed andjava.util.concurrent.ConcurrentHashMapcan be used instead. This also has the advantage of removing somesun.misc.Unsafeusages from Jersey proper.Similarly there was a
LinkedTransferQueueimplementation for Java 6 and older. I've removed this too, and theJdkVersionutility class (which was also not ready to support Java 11 version strings) along with it.Signed-off-by: mszabo-wikia [email protected]