Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup old JDK collection compatibility classes #3979

Merged
merged 1 commit into from
Feb 19, 2019
Merged

Cleanup old JDK collection compatibility classes #3979

merged 1 commit into from
Feb 19, 2019

Conversation

mszabo-wikia
Copy link
Contributor

@mszabo-wikia mszabo-wikia commented Oct 31, 2018

Remove the following package-private compatibility classes that serve no purpose in Java 8 and above:

  • org.glassfish.jersey.internal.util.collection.ConcurrentHashMapV8
  • org.glassfish.jersey.internal.util.collection.LinkedTransferQueue
  • org.glassfish.jersey.internal.util.collection.ThreadLocalRandom

The public factory methods in org.glassfish.jersey.internal.util.collection.DataStructures that originally instantiated these classes were modified to always return the JDK equivalents of these classes. Additionally, the methods were marked as @Deprecated and method documentations were updated to clarify that callers can now simply instantiate the required JDK collection class without having to use these factories. Use of these factories inside Jersey itself was removed.

Finally, the org.glassfish.jersey.internal.util.JdkVersion class was updated to allow it to properly handle new version strings used for Java 9 and above, and unit tests were added to cover this logic.

This is a re-implementation of #3976

Signed-off-by: mszabo-wikia [email protected]

@senivam senivam merged commit 4ae3004 into eclipse-ee4j:master Feb 19, 2019
@senivam senivam added the 2.29 label Feb 19, 2019
@mszabo-wikia mszabo-wikia deleted the compatibility-classes-cleanup branch February 19, 2019 11:48
@senivam senivam added this to the 2.29 milestone Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants