Rewritten Netty Jersey implementation using direct ByteBuf consumption #4312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
010gvr
force-pushed
the
feat/netty-bytebuf
branch
2 times, most recently
from
dc2c3c7
to
9e9a096
Compare
Signed-off-by: Venkat Ganesh <[email protected]>
010gvr
force-pushed
the
feat/netty-bytebuf
branch
from
9e9a096
to
30dbb3e
Compare
|
Any interest in this? |
senivam
approved these changes
Nov 26, 2019
jansupol
approved these changes
Nov 28, 2019
010gvr
pushed a commit
to 010gvr/jersey
that referenced
this pull request
Nov 30, 2019
Current unit tests only validate Netty's `JerseyClientHandler` against a Grizzly http server. This commit adds test cases to validate the same using Netty's `JerseyServerHandler`. Also adding extra test cases to effectively validate the bug fixes for eclipse-ee4j#3500 and eclipse-ee4j#3568 (that is, these new test cases will fail if ran against the code base older than eclipse-ee4j#4312) Fixes eclipse-ee4j#3500 and eclipse-ee4j#3568 Signed-off-by: Venkat Ganesh <[email protected]>
010gvr
pushed a commit
to 010gvr/jersey
that referenced
this pull request
Nov 30, 2019
Current unit tests only validate Netty's `JerseyClientHandler` against a Grizzly http server. This commit adds test cases to validate the same using Netty's `JerseyServerHandler` using `NettyTestContainerFactory`. Also adding extra test cases to effectively validate the bug fixes for eclipse-ee4j#3500 and eclipse-ee4j#3568 (that is, these new test cases will fail if ran against the code base older than eclipse-ee4j#4312) Fixes eclipse-ee4j#3500 and eclipse-ee4j#3568 Signed-off-by: Venkat Ganesh <[email protected]>
010gvr
pushed a commit
to 010gvr/jersey
that referenced
this pull request
Nov 30, 2019
Current unit tests only validate Netty's `JerseyClientHandler` against a Grizzly http server. This commit adds test cases to validate the same using Netty's `JerseyServerHandler` using `NettyTestContainerFactory`. Also adding extra test cases to effectively validate the bug fixes for eclipse-ee4j#3500 and eclipse-ee4j#3568 (that is, these new test cases will fail if ran against the code base older than eclipse-ee4j#4312) Fixes eclipse-ee4j#3500 and eclipse-ee4j#3568 Signed-off-by: Venkat Ganesh <[email protected]>
010gvr
added a commit
to 010gvr/jersey
that referenced
this pull request
Nov 30, 2019
Current unit tests only validate Netty's `JerseyClientHandler` against a Grizzly http server. This commit adds test cases to validate the same using Netty's `JerseyServerHandler` using `NettyTestContainerFactory`. Also adding extra test cases to effectively validate the bug fixes for eclipse-ee4j#3500 and eclipse-ee4j#3568 (that is, these new test cases will fail if ran against the code base older than eclipse-ee4j#4312) Fixes eclipse-ee4j#3500 and eclipse-ee4j#3568 Signed-off-by: Venkat Ganesh <[email protected]>
010gvr
added a commit
to 010gvr/jersey
that referenced
this pull request
Nov 30, 2019
Current unit tests only validate Netty's `JerseyClientHandler` against a Grizzly http server. This commit adds test cases to validate the same using Netty's `JerseyServerHandler` using `NettyTestContainerFactory`. Also adding extra test cases to effectively validate the bug fixes for eclipse-ee4j#3500 and eclipse-ee4j#3568 (that is, these new test cases will fail if ran against the code base older than eclipse-ee4j#4312) Fixes eclipse-ee4j#3500 and eclipse-ee4j#3568 Signed-off-by: Venkat Ganesh <[email protected]>
010gvr
added a commit
to 010gvr/jersey
that referenced
this pull request
Dec 1, 2019
Current unit tests only validate Netty's `JerseyClientHandler` against a Grizzly http server. This commit adds test cases to validate the same using Netty's `JerseyServerHandler` using `NettyTestContainerFactory`. Also adding extra test cases to effectively validate the bug fixes for eclipse-ee4j#3500 and eclipse-ee4j#3568 (that is, these new test cases will fail if ran against the code base older than eclipse-ee4j#4312) Fixes eclipse-ee4j#3500 and eclipse-ee4j#3568 Signed-off-by: Venkat Ganesh <[email protected]>
010gvr
added a commit
to 010gvr/jersey
that referenced
this pull request
Dec 1, 2019
Current unit tests only validate Netty's `JerseyClientHandler` against a Grizzly http server. This commit adds test cases to validate the same using Netty's `JerseyServerHandler` using `NettyTestContainerFactory`. Also adding extra test cases to effectively validate the bug fixes for eclipse-ee4j#3500 and eclipse-ee4j#3568 (that is, these new test cases will fail if ran against the code base older than eclipse-ee4j#4312) Fixes eclipse-ee4j#3500 and eclipse-ee4j#3568 Signed-off-by: Venkat Ganesh <[email protected]>
This was referenced Jun 26, 2021
This was referenced Aug 5, 2021
This was referenced Aug 29, 2021
1 task
This was referenced Dec 9, 2021
1 task
1 task
This was referenced Mar 7, 2022
This was referenced Mar 15, 2022
This was referenced Apr 17, 2022
This was referenced May 3, 2022
1 task
1 task
This was referenced Oct 19, 2022
1 task
1 task
1 task
1 task
1 task
Open
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit contains a rewritten implementation of Netty Jersey server and client with the following major changes:
ByteBufs fromHttpContentas-is for processing, reduces a lot of overhead.ChunkedInputbuffer properties throughjersey.ci.capacity,jersey.ci.read.timeoutandjersey.ci.write.timeoutjersey.max.http.request.entitySizeMb, defaults to 50 MbThis change should fix some of the long pending bug reports in #3500 , #3568 and #4286 . This may also resolve #4285
Signed-off-by: Venkat Ganesh [email protected]