Unit tests for Jersey Netty Http Container #4329
Open
+681
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @senivam @jansupol Thanks for merging #4312. Just to avoid future regression, I've added a few missing test cases. You may confirm this commit by simply running these tests again commits older than 8dcfed4 and the following two tests would fail:
|
010gvr
force-pushed
the
test/netty
branch
2 times, most recently
from
e1b08df
to
0987c2a
Compare
Current unit tests only validate Netty's `JerseyClientHandler` against a Grizzly http server. This commit adds test cases to validate the same using Netty's `JerseyServerHandler` using `NettyTestContainerFactory`. Also adding extra test cases to effectively validate the bug fixes for eclipse-ee4j#3500 and eclipse-ee4j#3568 (that is, these new test cases will fail if ran against the code base older than eclipse-ee4j#4312) Fixes eclipse-ee4j#3500 and eclipse-ee4j#3568 Signed-off-by: Venkat Ganesh <[email protected]>
|
the travis node running tests on openjdk11 seems a bit flaky. If there's a build failure, it's more likely due to that. |
|
Bump... Possible to get this in before next release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current unit tests only validate Netty's
JerseyClientHandleragainst a Grizzly http server. This commit adds test cases to validate the same using Netty'sJerseyServerHandlerusingNettyTestContainerFactory.Also adding extra test cases to effectively validate the bug fixes for #3500 and #3568 (that is, these new test cases will fail if ran against the code base older than #4312)
Fixes #3500 and #3568
Signed-off-by: Venkat Ganesh [email protected]