Update CHANGELOG.md #461
Merged
Update CHANGELOG.md #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
About semanticTokens side, AFAIK this would be the only breaking change: #457 but it was not implemented yet (and maybe it should be for the next release?) |
|
Thanks @spoenemann for raising this. The readme also needs an update: https://github.com/eclipse/lsp4j/blob/0faac0cc5d1dc51f45b9c7540ad9b94eef38ddca/README.md#supported-lsp-versions |
|
The only potentially breaking change with my contributions is that |
|
I think I don’t have breaking change.
I only append fields or parent class. I don’t remove anything.
Le mar. 27 oct. 2020 à 21:37, KamasamaK <[email protected]> a écrit :
… The only potentially breaking change with my contributions is that
DocumentOnTypeFormattingParams now extends TextDocumentPositionParams
instead of DocumentFormattingParams. Also, DocumentRangeFormattingParams
no longer extends DocumentFormattingParams. I doubt that would actually
result in breaking anything, but I suppose it's possible.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#461 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABZ5G7ED5OXD4OZ2NALWKLSM4VPJANCNFSM4TAYOSQA>
.
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a preparation for the upcoming release 0.10.0.
We should track all breaking changes. @KamasamaK @Dufgui @ericdallo could you help with this? Are you aware of any breaking changes that came with your contributions?
CC @jonahgraham