Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing Semantic Highlighting #457

Closed
KamasamaK opened this issue Oct 20, 2020 · 4 comments · Fixed by #482
Closed

Removing Semantic Highlighting #457

KamasamaK opened this issue Oct 20, 2020 · 4 comments · Fixed by #482
Milestone
v0.11.0

Comments

@KamasamaK
Copy link
Contributor

Given this, should we remove or deprecate semantic highlights as semantic tokens replace it?

Originally posted by @ericdallo in #446 (comment)

This question was never addressed, so I'm creating a separate issue for it. Now that Semantic Tokens are officially in the LSP 3.16 proposal and implemented in LSP4J, the Semantic Highlighting operations should be removed or deprecated. What is the view on beta/experimental features? Should they just be removed or should they be deprecated first even though they were never finalized?
@ericdallo ericdallo mentioned this issue Oct 27, 2020
Merged
@spoenemann
Copy link
Contributor

The @Beta annotation says something like "use at your own risk, this might change or be removed". Nonetheless it would make sense to add @Deprecated to the affected parts of the API before our 0.10.0 release and remove them after the release.

@KamasamaK KamasamaK mentioned this issue Oct 28, 2020
Merged
@KamasamaK
Copy link
Contributor Author

I've added @Deprecated to the Semantic Highlighting API. I will remove that API some time after 0.10.0 release.

@KamasamaK KamasamaK mentioned this issue Dec 7, 2020
Merged
@KamasamaK
Copy link
Contributor Author

@kittaakos As the one who created the semantic highlighting API, how do you feel about the timeline of its removal?

@KamasamaK KamasamaK mentioned this issue Dec 27, 2020
Merged
@kittaakos
Copy link
Contributor

@KamasamaK, thank you for keeping an eye on this. 👍 Please, feel free to remove the unused APIs. I do not have any obejctions.

kjeremy added a commit to kjeremy/languageserver-types that referenced this issue Jan 20, 2021
@kjeremy
Remove the SemanticHighlighting feature
c6bedc0 
This was a proposed feature that never made it to stable and was superceded by Semantic Tokens

See: eclipse-lsp4j/lsp4j#457

Closes gluon-lang#182
@kjeremy kjeremy mentioned this issue Jan 20, 2021
Merged
@jonahgraham jonahgraham added this to the v0.11.0 milestone Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging a pull request may close this issue.

Remove Semantic Highlighting API KamasamaK/lsp4j
4 participants
@jonahgraham @kittaakos @spoenemann @KamasamaK