Skip to content

Commit

Permalink
Remove the SemanticHighlighting feature
Browse files Browse the repository at this point in the history
This was a proposed feature that never made it to stable and was superceded by Semantic Tokens

See: eclipse-lsp4j/lsp4j#457

Closes gluon-lang#182
  • Loading branch information
kjeremy committed Jan 20, 2021
1 parent 1be3254 commit c6bedc0
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 179 deletions.
1 change: 0 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ serde = { version = "1.0.34", features = ["derive"] }
serde_json = "1.0.50"
serde_repr = "0.1"
url = {version = "2.0.0", features = ["serde"]}
base64 = "0.12.0"

[features]
default = []
Expand Down
15 changes: 0 additions & 15 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -85,11 +85,6 @@ pub use rename::*;
pub mod selection_range;
pub use selection_range::*;

#[cfg(feature = "proposed")]
mod semantic_highlighting;
#[cfg(feature = "proposed")]
pub use semantic_highlighting::*;

mod semantic_tokens;
pub use semantic_tokens::*;

Expand Down Expand Up @@ -1359,11 +1354,6 @@ pub struct TextDocumentClientCapabilities {
#[serde(skip_serializing_if = "Option::is_none")]
pub linked_editing_range: Option<LinkedEditingRangeClientCapabilities>,

/// The client's semantic highlighting capability.
#[cfg(feature = "proposed")]
#[serde(skip_serializing_if = "Option::is_none")]
pub semantic_highlighting_capabilities: Option<SemanticHighlightingClientCapability>,

/// Capabilities specific to the various call hierarchy requests.
///
/// @since 3.16.0
Expand Down Expand Up @@ -1715,11 +1705,6 @@ pub struct ServerCapabilities {
#[serde(skip_serializing_if = "Option::is_none")]
pub workspace: Option<WorkspaceServerCapabilities>,

/// Semantic highlighting server capabilities.
#[cfg(feature = "proposed")]
#[serde(skip_serializing_if = "Option::is_none")]
pub semantic_highlighting: Option<SemanticHighlightingServerCapability>,

/// Call hierarchy provider capabilities.
#[serde(skip_serializing_if = "Option::is_none")]
pub call_hierarchy_provider: Option<CallHierarchyServerCapability>,
Expand Down
19 changes: 1 addition & 18 deletions src/notification.rs
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,6 @@ macro_rules! lsp_notification {
("$/progress") => {
$crate::notification::Progress
};
// Requires #[cfg(feature = "proposed")]
("textDocument/semanticHighlighting") => {
$crate::notification::SemanticHighlighting
};
("workspace/didCreateFiles") => {
$crate::notification::DidCreateFiles
};
Expand Down Expand Up @@ -257,17 +253,6 @@ impl Notification for WorkDoneProgressCancel {
const METHOD: &'static str = "window/workDoneProgress/cancel";
}

#[cfg(feature = "proposed")]
/// Diagnostics notification are sent from the server to the client to signal results of validation runs.
#[derive(Debug)]
pub enum SemanticHighlighting {}

#[cfg(feature = "proposed")]
impl Notification for SemanticHighlighting {
type Params = SemanticHighlightingParams;
const METHOD: &'static str = "textDocument/semanticHighlighting";
}

/// The did create files notification is sent from the client to the server when files were created from within the client.
#[derive(Debug)]
pub enum DidCreateFiles {}
Expand Down Expand Up @@ -341,7 +326,5 @@ mod test {

#[test]
#[cfg(feature = "proposed")]
fn check_proposed_macro_definitions() {
check_macro!("textDocument/semanticHighlighting");
}
fn check_proposed_macro_definitions() {}
}
145 changes: 0 additions & 145 deletions src/semantic_highlighting.rs

This file was deleted.

0 comments on commit c6bedc0

Please sign in to comment.