Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added MongoDB implementation for alteration storage #5555

Conversation

rosca-sabina
Copy link
Contributor

@rosca-sabina rosca-sabina commented Jun 7, 2024

This PR provides a MongoDB implementation for interfaces IAlterationJobStore and IAlterationPlanStore, using the existing MongoDbStore class.

This solves issue #5554.


This change is Reviewable

@rosca-sabina rosca-sabina force-pushed the feature/mongodb-alterations-store branch from 4546745 to fad0084 Compare June 7, 2024 17:47
@rosca-sabina
Copy link
Contributor Author

@dotnet-policy-service agree

Copy link
Member

@sfmskywalker sfmskywalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice - thanks!

@sfmskywalker sfmskywalker merged commit da7bff8 into elsa-workflows:main Jun 9, 2024
2 checks passed
@rosca-sabina
Copy link
Contributor Author

Very nice - thanks!

No problem, thank you for such a quick review!

@rosca-sabina
Copy link
Contributor Author

@sfmskywalker I actually opened another PR to fix an issue I introduced here: #5564 . I basically forgot to push all my changes when I opened this one and some services were missing from DI as a result 🤦. Really sorry!

@sfmskywalker
Copy link
Member

No problem at all - thanks for the quick action!

@rosca-sabina rosca-sabina deleted the feature/mongodb-alterations-store branch June 9, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants