Fixed DI registration for MongoAlterationPlanStore #5564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DI issue related to
MongoAlterationPlanStoreintroduced in #5555.MongoDbStore<AlterationPlanDocument>andIMongoCollection<AlterationPlanDocument>weren't actually registered in the DI container, so trying to resolve them fromIServiceProviderfailed.This was caused by me not committing all changes when I refactored how they were resolved in
MongoAlterationPlanStore's constructor: initially I was instantiating them usingIMongoDatabase, but when I refactored the constructor to resolve them from the DI container I actually forgot to commit and push all the changes I made before opening a PR.I re-tested everything and it works as expected now. Sorry!
This change is