This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Change user buttons to as. Allows highlighting on firefox. #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astorije
added a commit
that referenced
this pull request
Jan 9, 2016
Change user buttons to as. Allows highlighting on firefox.
|
Any side effect on this? In particular, empty |
|
Dumb dumb dumb dumb me! I clicked "Merge" instead of "Comment", and force of daily habit I confirmed the merge right before realizing I made a mistake! Duh! Sorry but do you mind reopening a PR please? :-/ |
|
Hmmm, github says that there are no differences now between my branch and master, so I can't open a new PR. |
|
Also, woops I did mean to put href="#", not sure why I didn't. I'll update that. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On firefox, we can't copy the usernames when it is a button. Change to span.