-
Notifications
You must be signed in to change notification settings - Fork 273
Conversation
What I can see of the previews from my phone looks good. Perfect or not, this is a big step forward from how it looks now. 👍 |
See #571, though. The user |
Never mind, it moved to #574 and still needs review. But the change will probably be merged. |
+1 looks awesome |
color: #ccc; | ||
display: none; | ||
font-style: normal; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xPaw, what does that remove already?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you can see in the msg
template, <em class="type">{{type}}</em>
was removed as it's not needed anymore, it was used to display the action.
@xPaw, I left you a bunch of minor comments inline. This looks pretty awesome, really! |
@astorije I've added font awesome icons, looks pretty cool. |
Wheren't you against bold/italic/colors in topic line? I'm OK with anything at the moment really. |
} | ||
#chat .kick .from:before { | ||
font-family: FontAwesome; | ||
content: "\f00d"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For /kick
, I'm not too fond of this icon, usually used for closing something and sometimes for deleting (but less and less, I notice).
I think I'd prefer ban
(https://fortawesome.github.io/Font-Awesome/icon/ban/). If really you don't like it, the same icon as leave would work as the consequences are the same (the user leaves the channel) although I still prefer ban
to that.
Alternatives could be:
- https://fortawesome.github.io/Font-Awesome/icon/exclamation-triangle/
- https://fortawesome.github.io/Font-Awesome/icon/exclamation-circle/
- https://fortawesome.github.io/Font-Awesome/icon/exclamation/
But these I would prefer to notify a warning within the app.
And if really we want to go esoteric, these could do:
- https://fortawesome.github.io/Font-Awesome/icon/flag/
- https://fortawesome.github.io/Font-Awesome/icon/bolt/
- https://fortawesome.github.io/Font-Awesome/icon/crosshairs/
- https://fortawesome.github.io/Font-Awesome/icon/crosshairs/
- https://fortawesome.github.io/Font-Awesome/icon/thumbs-o-down/
- https://fortawesome.github.io/Font-Awesome/icon/frown-o/
- https://fortawesome.github.io/Font-Awesome/icon/bomb/
Meh, ban
still conveys the most meaning, IMO :-)
These do look pretty cool... I look forward to that! :-) |
I don't think this should have been merged already, while the discussion was ongoing... but nevermind... |
This fixes #577, #404.
Needs to be done before merging this: