Allow test framework to use cores/esp8266/Arduino.h directly

[mcspr]

resolve #7359 , @d-a-v

• Removes 'tests/host/common/Arduino.h' in favor of 'cores/esp8266/Arduino.h'
• Clean-up math imports, comment some reasoning behind define / undef
• Add a small example that does not build with the current master

Some minor stuff

• Esp.h change is cosmetic, we might as well use class body instead of this weird forced inline definition
• I also noticed malloc debug include at the end

#ifdef DEBUG_ESP_OOM
// reinclude *alloc redefinition because of <cstdlib> undefining them
// this is mandatory for allowing OOM *alloc definitions in .ino files
#include "umm_malloc/umm_malloc_cfg.h"

This does not cause any issues since mock does not set DEBUG_ESP_OOM, but it is unclear why it is outside of guards and whether it should be some place else ('core_esp8266_... .h'?)

[devyte]

Fixes #5530 as well, if the abs and round changes are ok (I haven't checked in detail)

[d-a-v]

from OP:

I also noticed malloc debug include at the end

This is history. Files and dependencies have changed from that time.
Maybe it can be moved in a better place like you suggest.

[d-a-v]

While testing tests/device/test_sw_arduino_math_overrides, I had to add #include <cerrno> in tests/host/common/{litlefs,spiffs}_mock.cpp. Maybe because my host gcc version is 10.

Thanks for this work, it is always good to remove complexity and duplicate code !

[dok-net]

In libraries/ESP8266WiFi/src/BearSSLHelpers.cpp, libraries/ESP8266WiFi/src/ESP8266WiFiSTA.cpp, libraries/ESP8266WiFi/src/WiFiClientSecureBearSSL.cpp, tests/device/test_sw_http_client/test_sw_http_client.ino there are

#if !CORE_MOCK

instead of the (canonical)

#ifndef CORE_MOCK

Could this be fixed/streamlined in the course of this PR as well?

[mcspr]

While testing tests/device/test_sw_arduino_math_overrides, I had to add #include in tests/host/common/{litlefs,spiffs}_mock.cpp. Maybe because my host gcc version is 10.

will update, seeing this too (was jumping between gcc-9 and gcc-10 machines...)

common/littlefs_mock.cpp:34:1: note: ‘errno’ is defined in header ‘<cerrno>’; did you forget to ‘#include <cerrno>’?
   33 | #include <unistd.h>
  +++ |+#include <cerrno>
   34 | #include "flash_hal_mock.h"
...
common/spiffs_mock.cpp:29:1: note: ‘errno’ is defined in header ‘<cerrno>’; did you forget to ‘#include <cerrno>’?
   28 | #include <unistd.h>
  +++ |+#include <cerrno>
   29 |
...

In libraries/ESP8266WiFi/src/BearSSLHelpers.cpp, libraries/ESP8266WiFi/src/ESP8266WiFiSTA.cpp, libraries/ESP8266WiFi/src/WiFiClientSecureBearSSL.cpp, tests/device/test_sw_http_client/test_sw_http_client.ino there are

#if !CORE_MOCK

instead of the (canonical)

#ifndef CORE_MOCK

Could this be fixed/streamlined in the course of this PR as well?

🤷
this would also require changing mock.h to a plain #define CORE_MOCK so that does not happen in the future
besides, that that is only cosmetic and might as well be added after?

bearssl(helpers|client) needs to change
littlefs comment is definitely wrong
http_client test does not need ifndef'ed block at all because axtls is removed

[d-a-v]

Minimum for -std=c17 is 8.x.0, but my understanding is we would need to call it via gcc-{8,9}, same as g++-{7,8,9}

It seems gcc-8 is bundled with ubuntu-latest that we use in CI.

Maybe that could be useful

diff --git a/tests/host/Makefile b/tests/host/Makefile
index 1c534356..b1785d83 100644
--- a/tests/host/Makefile
+++ b/tests/host/Makefile
@@ -11,6 +11,11 @@ DEFSYM_FS ?= -Wl,--defsym,_FS_start=0x40300000 -Wl,--defsym,_FS_end=0x411FA000 -
 
 MAKEFILE = $(word 1, $(MAKEFILE_LIST))
 
+ifeq ($(shell g++-8 -v; echo $$?),0)
+CC  = gcc-8
+CXX = g++-8
+endif
+

[d-a-v]

@mcspr do you intend to fix these conflicts ?

[mcspr]

Done.
What's holding this, anyway?

[devyte]

Me, I need to re-review.
Don't forget to please mark resolved comments as, well, resolved :)
I expect to take a look later today.

[devyte]

Apologies for taking so long!

[earlephilhower]

@mcspr we now have a merge conflict in Arduino that I can't fix via the Web GUI. Can you please do a manual merge and re-push so we can pull this into master?

[mcspr]

Sure, will do (as sooon as I have more than 5min at the PC...)
a3281fe#diff-32484ac1bbd2e6ea02f4b86b76c2e0a2 seems to be the only change, but I am not yet sure what that change is supposed to be doing

[d-a-v]

Merge error is indeed:

CONFLICT (modify/delete): tests/host/common/Arduino.h deleted in HEAD and modified in master. Version master of tests/host/common/Arduino.h left in tree.

@@ -270,3 +270,10 @@ extern "C" void configTime(long timezone, int daylightOffset_sec,
 #include "pins_arduino.h"
 
 #endif /* Arduino_h */
+
+#if __cplusplus
+#include <WString.h>
+#include <map>
+#define MOCKARGS 1
+extern std::map<String,String> mockArgs;
+#endif

After inspection, MOCKARGS is unused anywhere, and mockArgs is only used in ArduinoMain.cpp. These are potential helpers, unused in the core, that I added to allow mocking with parameters without recompilation in user (mocking) sketches.
I think you can ignore/remove them in your PR. They shall be shared in another emulation-specific header file.

[mcspr]

These are potential helpers, unused in the core, that I added to allow mocking with parameters without recompilation in user (mocking) sketches.

Thanks for clarifying. But, any reason why not just use {get,set}env instead?

[d-a-v]

But, any reason why not just use {get,set}env instead?

Not a single tiny one 😊
I will remove this key/value facility asap

edit1: (after your PR is merged)
edit2: (updating branch now)
edit3: I just noticed you already removed it, thanks !