Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING: Change return EEPROM.end() to bool #7630

Merged
merged 3 commits into from
Oct 15, 2020
Merged

BREAKING: Change return EEPROM.end() to bool #7630

merged 3 commits into from
Oct 15, 2020

Conversation

Erriez
Copy link
Contributor

@Erriez Erriez commented Oct 3, 2020

As requested in #7423.

earlephilhower
earlephilhower approved these changes Oct 3, 2020
View reviewed changes
Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This will diverge slightly from the base Arduino EEPROM class, now, but be forward compatible.

@earlephilhower earlephilhower changed the title Issue #7423: Change return EEPROM.end() to bool BREAKING: Change return EEPROM.end() to bool Oct 15, 2020
@earlephilhower earlephilhower merged commit e79eb11 into esp8266:master Oct 15, 2020
@Erriez Erriez deleted the feature/issue-7423-eeprom-end-return-bool branch October 16, 2020 06:20
davisonja added a commit to davisonja/Arduino that referenced this pull request Oct 16, 2020
@davisonja
Merge branch 'master' into ota_commands_in_flash
4d64292 
* master: (37 commits)
  BREAKING: Change return EEPROM.end() to bool (esp8266#7630)
  BREAKING: Change return type of channel() (esp8266#7656)
  BREAKING: Change return type of RSSI() (esp8266#7657)
  Add Copyright notice to Schedule.h (esp8266#7653)
  MDNS MultiInterface (esp8266#7636)
  BREAKING: Add Wrong Password wifi status case (esp8266#7652)
  New flash writing method with offset/memory/size alignment handling (esp8266#7514)
  Fix error when debug enabled but no port chosen (esp8266#7648)
  LEAmDNSv2: change a macro name to be independant from LEAmDNS1 (esp8266#7640)
  Allow test framework to use cores/esp8266/Arduino.h directly (esp8266#7377)
  Update OTA HTTP Server Header Information (esp8266#7633)
  Add missing sntp_init/sntp_stop (esp8266#7628)
  Use direct member initialization instead of ctr initialisation (esp8266#7558)
  Prevent rewriting Updater_Signing.h if content unchanged (esp8266#7627)
  Add WiFi Multi to readme.rst
  Remove stray axtls refs, deprecated compat funcs (esp8266#7626)
  Pull deprecated axtls link (esp8266#7624)
  Redesign ESP8266WiFiMulti.[cpp|h]
  Update README.md (esp8266#7623)
  Eliminate code duplication by template for printNumber(...)/printFloat(...).
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@earlephilhower earlephilhower earlephilhower approved these changes

Assignees
No one assigned
Labels
component: libraries hacktoberfest-accepted Hacktoberfest type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Erriez @earlephilhower