-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve language support #4
Comments
We would love to provide you german and french translations. Let me know how to start. |
Hurraaaay! That's great. Thanks for offering to help. The files that need translation are here: https://github.com/etewiah/property_web_builder/tree/master/config/locales Each file ends with a ".language_code.yml" extension so as you can see all that remains for me to complete the French translations is the admin.fr.yml file. For the German translations I need to start from scratch. I can obtain the translations for devise.de.yml and rails.de.yml so don't worry about those - I will add them in the next few hours. It will be really great to have the remaining translations done. Are you familiar with pull requests? There are also some seed files that I use to populate the website with example data. It would be good to translate those too but first I need to figure out a better way of organising them. If anything is not clear or you have any questions, just let me know. If you wish, we could arrange a skype call to discuss any issues. Thanks again for offering to help. |
Hi @beeyatch, I never heard back from you. Still able to help? |
@etewiah I can help with German, not much with French though. |
@cvillalba that would be awesome. Are my instructions clear enough for you to be able to start on that? |
@etewiah yeah, no problem. It will be done in a couple of days |
Hi all, Thanks to the awesome i18n-tasks project by @glebm I am able to generate locale files using google translate. The translations are not perfect of course but it means I have a starting point which should make the process easier. I now have these google translated files which I need to have verified: https://github.com/etewiah/property_web_builder/blob/master/config/locales/ru.yml If anyone gets the chance, please have a look. You can just paste the changes that need to be made in a comment here or send me an email if creating a pull request is too much work ;) |
I can provide you Chinese (Traditional-hk) translation. Can you make the locale files? :-) |
Hi @bluesky321 , thanks a lot for the offer. I've just added the locale file here: https://github.com/etewiah/property_web_builder/blob/master/config/locales/zh-HK.yml Looking forward to the translations. Please let me know if you need help with anything at all. |
Hi @bluesky321, @beeyatch - are either of you going to actually help? It's a bit disappointing to get offers of help which end in nothing :( |
please make locale file for Vietnamese! |
Hi @anhpham2710 , I will create the locale files but please don't disappoint me like @bluesky321 and @beeyatch did. |
no man, I will try all my best |
Hi @anhpham2710, I have just added the locale file for Vietnamese: https://github.com/etewiah/property_web_builder/blob/master/config/locales/vi.yml Right now it contains translations from google. Please correct them and send me a pull request when you are ready. Thanks |
Pull request is sent, please merge ;) |
That's great - much quicker than I expected ;) |
Okay, so I've just deployed with your changes to heroku: https://propertywebbuilder.herokuapp.com/vi Right now you cannot set Vietnamese as a supported language in the admin section. I will enable that tomorrow and push it out. |
look cool, so fast and furious too ;) |
Thanks - there are some nice new features in the pipeline too. Drop me an email (ed at propertywebbuilder.com) and let's have a chat tomorrow. |
Would love to help out for Italian localization, let me know. |
Just finished translating from EN to IT |
Mille grazie @Zaldor - much appreciated. Just added it now ;) There are also some editable strings for which I'd like to set the default values for each locale. I have created a placeholder file for those values in Italian here: https://github.com/etewiah/property_web_builder/blob/master/db/seeds/translations_it.rb If you get a chance and can translate those, that would be great as well. As those values can be edited by a user through the admin panel it is not essential that I populate them beforehand but its a nice to have. Hope that makes sense. I will prepare a page in the Wiki explaining a bit more about the different translations and how they work. Thanks again for your contribution. |
I'll do it later today. |
Shouldn't the property types be in all in English? |
Thanks @Zaldor, that will be great. The keys for some items (like "propertyTypes.apartamento") are that way because I started off with a legacy system. They are only used internally anyway so doesn't matter too much. I used the Spanish translations as a placeholder for the Italian one as I figured they would be more similar. If you prefer to start with the English translations you will find them here: https://github.com/etewiah/property_web_builder/blob/master/db/seeds/translations_en.rb |
Hi @Zaldor, did you get the chance to look at the translations here: https://github.com/etewiah/property_web_builder/blob/master/db/seeds/translations_it.rb |
I Ed, yes I actually did, and I wanted to ask you if it could be possible
to use any more "automated" method like with PO files, Transifex is very
nice.
But after i was cought by busy life and totally forgot to ask, sorry.
I will look again at it and translate it.
…On Tue, 12 Dec 2017 at 13:17 Ed Tewiah ***@***.***> wrote:
Hi @Zaldor <https://github.com/zaldor>, did you get the chance to look at
the translations here:
https://github.com/etewiah/property_web_builder/blob/master/db/seeds/translations_it.rb
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AD4jkltevuZ92WH78R8Vnloy89fIEAThks5s_m7agaJpZM4Lgs3g>
.
|
Thanks @Zaldor, send me the translations when you have them ready. I have looked at automated methods but for this project it is not worthwhile. There are not so many translations and each automated method has a downside. In the case of Transifex it is quite expensive and so far I have not made any money from this project so I cannot spend money on a service like that :( |
I realise now that it is not very obvious which files need to be created in order to add support for a new language so I put together this guide: https://github.com/etewiah/property_web_builder/wiki/Adding-translations-for-a-new-language |
Hi @etewiah |
Hi @tatyana12, @NickSchimek, Russian is already supported as you can see on the demo site: http://propertywebbuilder.herokuapp.com/ru/p/sell From the admin panel it is possible to add or remove Russian as a language |
Hello, "The best realtor in London How can I see (if it is done) the complete Russian version of this real estate website or if you need any help to make a complete and proper translation to Russian? |
Hi @tatyana12 , PropertyWebBuilder only translates the text for the menu etc (content that the user cannot edit). Text like "The best realtor in London" is editable by the user so PropertyWebBuilder does not provide these translations. If you look here you will see that you can edit the content yourself: http://propertywebbuilder.herokuapp.com/ru/admin/pages/home/landing_hero |
I would like to add support for Thai language, should I follow this guide? -> https://github.com/etewiah/property_web_builder/wiki/Adding-translations-for-a-new-language |
Hello @deepcell , thanks for the offer. Yes that guide explains everything. |
Hi @etewiah , I will start that and as soon I finish, will send a PR for review. Have a nice day. |
@etewiah I would like to add Ukrainian translation if you are interested. |
Thanks @kolisnyklera , will be great to add Ukrainian but can I suggest you do this in the next month or 2? I am planning on releasing version 2 soon so will be better to add the new translations then. Thanks |
@etewiah I would like to help on Thai translation and use yours for my business :) |
Have u already done the job? |
Hi @nok5150 , thanks for your interest. It will be better to wait a couple of months till the new version is ready. If you would like to try out the beta, email me (ed at PropertyWebBuilder.com) |
@nok5150 not yet, business was slow for last few months, we just using the English translation for now, but yes if no one get this task done I will do myself soon. I will try the new version first and then look how to proceed with that. |
hi |
could you add support for Chinese simplified? |
@MohamedTay , @loganfreeman : I personally will not add Arabic or Chinese but this project is open source. You can go ahead and add any language you want.... |
So have you got the German done then? Otherwise ill start right now? |
Ok just checked it out but the translation is horrible and wrong at points. Ill look it over and send you a pullrequest when done. Greetings from Hamburg Germany |
Many thanks @rocknrollMarc , much appreciated! |
Hahahahah Ive actualy done the translation to the sample data but I cant do a pull request as my browser is to old and I dont have a newer machine here at hand so ill post the file here. Sorry for that. |
de: Wir sind stolz registrierte Mitglieder der National association of realtors zu sein. Registrierungsnummer 12121212 legal: content_html: main_content: Haftungsausschluss Das Internet-Team von Example RE ist bestrebt, Ihnen auf dieser Website nützliche, genaue und aktuelle Informationen zur Verfügung zu stellen. Dementsprechend hat Example RE versucht, korrekte Informationen und Materialien auf dieser Website auf dieser Website bereitzustellen, übernimmt jedoch keine Verantwortung für die Richtigkeit und Vollständigkeit dieser Informationen und Materialien auf dieser Website, übernimmt jedoch keine Verantwortung für die Richtigkeit und Vollständigkeit dieser Informationen oder Materialien. Example RE kann den Inhalt von Informationen oder Materialien, die auf dieser Website verfügbar sind, oder die darin beschriebenen Produkte jederzeit ohne vorherige Ankündigung ändern. Example RE ist jedoch nicht verpflichtet, die Informationen oder Materialien auf dieser Website zu aktualisieren, was dazu führen kann, dass sie veraltet sind. In Anzeigetafeln oder anderen Foren geäußerte Informationen und Meinungen entsprechen nicht unbedingt denen von Beispiel RE. Weder Example RE noch seine leitenden Angestellten, Direktoren, Mitarbeiter, Vertreter, Vertriebshändler oder verbundenen Unternehmen sind verantwortlich oder haftbar für Verluste (einschließlich, aber nicht beschränkt auf tatsächliche Schäden, Folgeschäden oder Bestrafungen), Haftung, Ansprüche oder sonstige Verletzungen oder Ursache im Zusammenhang mit oder aufgrund von Informationen, die auf der Website von Example RE veröffentlicht wurden. Example RE behält sich das Recht vor, diese Bedingungen und / oder rechtlichen Einschränkungen jederzeit zu ändern. Sie sind dafür verantwortlich, diese Seite von Zeit zu Zeit zu überprüfen, um sicherzustellen, dass die jeweils geltenden Bestimmungen und rechtlichen Beschränkungen eingehalten werden, da diese für Sie bindend sind. Bestimmte Bestimmungen dieser Bedingungen und rechtlichen Einschränkungen können durch ausdrücklich bezeichnete rechtliche Hinweise oder Bedingungen auf bestimmten Seiten dieser Website ersetzt werden. privacy: Datenschutz-Bestimmungen
Links zu Dritten
sell: Verkaufen Sie Ihre Immobilie mit unsUnser Engagement für Sie ist es, den höchsten Standard an Professionalität aufrechtzuerhalten und Ihnen dabei zu helfen, die besten Immobilienentscheidungen zu treffen. Sie möchten Ihre Immobilie mit vollem Vertrauen verkaufen. Dabei verdienen Sie unser Bestes. Unser Ziel bei Example Real Estate ist es, Ihnen einen außergewöhnlichen Service zu bieten und dabei Ihre Bedürfnisse in jedem Schritt des Verkaufsprozesses zu erfüllen. Regionale Expertise |
ok that isnt working give me you mail address or actualy you can get it of my repo maybe better.:) Ill look into some other issues later on. Im intersted in the api that workes for ember, I have some experience in ember and react so maybe ill do that to. I wrote you a mail some days ago telling you that i worked for a hotel real estate company , my father and I was actualy thinking of writing a complet app for the company but I love your project so thaat will be my project from now on two if I may. What I would realy like to integrate is a kind of CRM something like fatfree which is also an engine, maybe it workes out of the box ill also try that today and maybe make some changes. In the end it would also be nice to have a seprate front end maybe react or ember, what do you think? |
Hey Marc, I didn't receive an email from you but I've seen your email on your repo so I'll send you one now. Could work out great collaborating. I've already made some enhancements for short term rentals that might be useful for a hotel. I haven't had the chance to release that yet but I can share it with you privately. |
@rocknrollMarc , I cannot reach you via email - I get a notification back saying delivery failed because your inbox is full. Also tried reaching you via twitter. |
Hi @etewiah, great project you have here. Would love to help for Indonesian (ID) translation as I'm a native and have done several English to Indonesian translation project. thank you. |
Many thanks @aditbaco, the instructions for adding a new translation are here: https://github.com/etewiah/property_web_builder/wiki/Adding-translations-for-a-new-language If there is anything that is not clear in the instructions please let me know |
Closing this issue as I'm getting a lot of offers to add translations from people who have not read the docs and end up wasting time. If there is something about the instructions which you don't understand please open an issue about what specifically you need help with. |
Currently only English and Spanish are supported. I would like to add as many languages as possible. Its quite easy to create the files for any language and to populate it with basic translations from google. After that though I would need a native speaker to got through and make sure the translations are correct.
If you speak any language well enough to help with this please mention it here and we can work together to add that translation.
The text was updated successfully, but these errors were encountered: