Skip to content

Commit

Permalink
Merge pull request #747 from facebookresearch/reasonable-default-max-…
Browse files Browse the repository at this point in the history
…concurrent

Adding reasonable defaults to our examples for max concurrent units
  • Loading branch information
JackUrb committed Apr 8, 2022
2 parents 89e3904 + b1a6235 commit 124458c
Show file tree
Hide file tree
Showing 7 changed files with 16 additions and 0 deletions.
3 changes: 3 additions & 0 deletions examples/parlai_chat_task_demo/hydra_configs/conf/base.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,6 @@ mephisto:
world_file: ${task_dir}/demo_worlds.py
task_description_file: ${task_dir}/task_description.html
num_conversations: 1
task:
# We expect to be able to handle 25 concurrent conversations without issue
max_num_concurrent_units: 50 # 25 convos * 2 people per
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,5 @@ mephisto:
task_reward: 0.05
# NOTE will want real tags
task_tags: "mnist,drawing,models,correction"
# We expect to handle 25 people using the MNIST model at once
max_num_concurrent_units: 25
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,6 @@ mephisto:
task_reward: 0.05
# NOTE will want real tags
task_tags: "test,task,fix-me"
# NOTE Model-in-the-loop tasks need to be careful to configure only as many concurrent
# connections as their model can handle at once
max_num_concurrent_units: 40
2 changes: 2 additions & 0 deletions examples/simple_static_task/hydra_configs/conf/example.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,5 @@ mephisto:
task_description: "This is a simple test of static tasks."
task_reward: 0.3
task_tags: "static,task,testing"
# We expect to be able to handle 300 concurrent tasks without issue
max_num_concurrent_units: 300
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,5 @@ mephisto:
task_description: "This is a simple test of static tasks."
task_reward: 0.3
task_tags: "static,task,testing"
# We expect to be able to handle 300 concurrent tasks without issue
max_num_concurrent_units: 300
2 changes: 2 additions & 0 deletions examples/static_react_task/hydra_configs/conf/example.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,5 @@ mephisto:
task_description: "In this task, you'll be given a sentence. It is your job to rate it as either good or bad."
task_reward: 0.05
task_tags: "test,simple,button"
# We expect to be able to handle 300 concurrent tasks without issue
max_num_concurrent_units: 300
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,5 @@ mephisto:
task_description: "In this task, you'll be given a sentence. It is your job to rate it as either good or bad."
task_reward: 0.05
task_tags: "test,simple,button"
# We expect to be able to handle 300 concurrent tasks without issue
max_num_concurrent_units: 300

0 comments on commit 124458c

Please sign in to comment.