Adding reasonable defaults to our examples for max concurrent units #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
pringshia
reviewed
Apr 5, 2022
| @@ -8,3 +8,6 @@ mephisto: | |||
| world_file: ${task_dir}/demo_worlds.py | |||
| task_description_file: ${task_dir}/task_description.html | |||
| num_conversations: 1 | |||
| task: | |||
| # We expect to be able to handle 25 concurrent conversations without issue | |||
There was a problem hiding this comment.
is this a typo? Says 25 in the comment but 50 for the value...
There was a problem hiding this comment.
25 conversations, but they require 2 connected people per. I see the comment is misleading here, can make explicit
pringshia
reviewed
Apr 5, 2022
| @@ -8,3 +8,6 @@ mephisto: | |||
| world_file: ${task_dir}/demo_worlds.py | |||
| task_description_file: ${task_dir}/task_description.html | |||
| num_conversations: 1 | |||
| task: | |||
| # We expect to be able to handle 25 concurrent conversations without issue | |||
| max_num_concurrent_units: 50 | |||
pringshia
approved these changes
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Mostly just the title. As brought up in #746, not having these kinds of defaults means that if people use the default values they're more likely to hit a bad experience (too much server load) rather than be low utilization. To make the basic case better, I've selected some defaults that should be pretty good on this tradeoff (at least until we hit the point that we can use our
metricstooling to scale this dynamically... in version 2.0 or something).