Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding reasonable defaults to our examples for max concurrent units #747

Merged
merged 2 commits into from
Apr 8, 2022
Merged

Adding reasonable defaults to our examples for max concurrent units #747

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f0b70f
Adding reasonable defaults to our examples for max concurrent units
JackUrb Apr 4, 2022
b1a6235
Conversation clarification
JackUrb Apr 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions examples/parlai_chat_task_demo/hydra_configs/conf/base.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,6 @@ mephisto:
world_file: ${task_dir}/demo_worlds.py
task_description_file: ${task_dir}/task_description.html
num_conversations: 1
task:
# We expect to be able to handle 25 concurrent conversations without issue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a typo? Says 25 in the comment but 50 for the value...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

25 conversations, but they require 2 connected people per. I see the comment is misleading here, can make explicit

max_num_concurrent_units: 50
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

50 here^

2 changes: 2 additions & 0 deletions examples/remote_procedure/mnist/hydra_configs/conf/launch_with_local.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,5 @@ mephisto:
task_reward: 0.05
# NOTE will want real tags
task_tags: "mnist,drawing,models,correction"
# We expect to handle 25 people using the MNIST model at once
max_num_concurrent_units: 25
3 changes: 3 additions & 0 deletions examples/remote_procedure/template/hydra_configs/conf/launch_with_local.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,6 @@ mephisto:
task_reward: 0.05
# NOTE will want real tags
task_tags: "test,task,fix-me"
# NOTE Model-in-the-loop tasks need to be careful to configure only as many concurrent
# connections as their model can handle at once
max_num_concurrent_units: 40
2 changes: 2 additions & 0 deletions examples/simple_static_task/hydra_configs/conf/example.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,5 @@ mephisto:
task_description: "This is a simple test of static tasks."
task_reward: 0.3
task_tags: "static,task,testing"
# We expect to be able to handle 300 concurrent tasks without issue
max_num_concurrent_units: 300
2 changes: 2 additions & 0 deletions examples/simple_static_task/hydra_configs/conf/onboarding_example.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,5 @@ mephisto:
task_description: "This is a simple test of static tasks."
task_reward: 0.3
task_tags: "static,task,testing"
# We expect to be able to handle 300 concurrent tasks without issue
max_num_concurrent_units: 300
2 changes: 2 additions & 0 deletions examples/static_react_task/hydra_configs/conf/example.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,5 @@ mephisto:
task_description: "In this task, you'll be given a sentence. It is your job to rate it as either good or bad."
task_reward: 0.05
task_tags: "test,simple,button"
# We expect to be able to handle 300 concurrent tasks without issue
max_num_concurrent_units: 300
2 changes: 2 additions & 0 deletions examples/static_react_task/hydra_configs/conf/onboarding_example.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,5 @@ mephisto:
task_description: "In this task, you'll be given a sentence. It is your job to rate it as either good or bad."
task_reward: 0.05
task_tags: "test,simple,button"
# We expect to be able to handle 300 concurrent tasks without issue
max_num_concurrent_units: 300