Merge pull request #1047 from facebookresearch/add-prolific-unittests-2

Add unittests for Prolific integration (2)

mephisto/abstractions/providers/prolific/api/base_api_resource.py

@@ -89,6 +89,7 @@ def _base_request(
 
             elif method == HTTPMethod.DELETE:
                 response = requests.delete(url, headers=headers, json=params)
+
             else:
                 raise ProlificException("Invalid HTTP method.")
 
@@ -102,6 +103,10 @@ def _base_request(
 
             return result
 
+        except ProlificException:
+            # Reraise these errors further to avoid catching them in the latest `except` condition
+            raise
+
         except requests.exceptions.HTTPError as err:
             logger.error(f"{log_prefix} Request error: {err}. Response text: `{err.response.text}`")
             if err.response.status_code == status.HTTP_401_UNAUTHORIZED:

mephisto/abstractions/providers/prolific/api/status.py

@@ -5,6 +5,7 @@
 # LICENSE file in the root directory of this source tree.
 
 # 2xx
+HTTP_200_OK = 200
 HTTP_204_NO_CONTENT = 204
 
 # 4xx

mephisto/abstractions/providers/prolific/prolific_utils.py

@@ -541,6 +541,8 @@ def add_workers_to_qualification(
         )
         raise
 
+    return None
+
 
 def give_worker_qualification(
     client: ProlificClient,

test/abstractions/providers/prolific/__init__.py

@@ -0,0 +1,5 @@
+#!/usr/bin/env python3
+
+# Copyright (c) Facebook, Inc. and its affiliates.
+# This source code is licensed under the MIT license found in the
+# LICENSE file in the root directory of this source tree.

test/abstractions/providers/prolific/api/__init__.py

@@ -0,0 +1,5 @@
+#!/usr/bin/env python3
+
+# Copyright (c) Facebook, Inc. and its affiliates.
+# This source code is licensed under the MIT license found in the
+# LICENSE file in the root directory of this source tree.