Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unittests for Prolific integration (2) #1047

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Conversation

meta-paul
Copy link
Contributor

More unittests to cover prolific_utils module and BaseAPIResource instances

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 14, 2023
@meta-paul meta-paul requested a review from JackUrb August 14, 2023 21:14
@meta-paul meta-paul force-pushed the add-prolific-unittests-2 branch 2 times, most recently from 7403572 to ee8e2b5 Compare August 16, 2023 00:42
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 25.00% and project coverage change: -0.15% ⚠️

Comparison is base (fb909e7) 60.51% compared to head (ee8e2b5) 60.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1047      +/-   ##
==========================================
- Coverage   60.51%   60.36%   -0.15%     
==========================================
  Files         155      155              
  Lines       11807    11811       +4     
==========================================
- Hits         7145     7130      -15     
- Misses       4662     4681      +19     
Files Changed Coverage Δ
...ctions/providers/prolific/api/base_api_resource.py 44.31% <0.00%> (-1.04%) ⬇️
.../abstractions/providers/prolific/prolific_utils.py 19.07% <0.00%> (-0.06%) ⬇️
...isto/abstractions/providers/prolific/api/status.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@meta-paul meta-paul marked this pull request as ready for review August 16, 2023 00:53
@JackUrb JackUrb merged commit a5a90f2 into main Aug 16, 2023
12 of 13 checks passed
@JackUrb JackUrb deleted the add-prolific-unittests-2 branch August 16, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants