Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an event for default rule read shell configuration file #108

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

GLVSKiriti
Copy link
Contributor

@GLVSKiriti GLVSKiriti commented Mar 15, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind documentation

/kind tests

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area commands

/area pkg

/area events

What this PR does / why we need it:
Added an event for default rule read shell configuration file.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@GLVSKiriti
Copy link
Contributor Author

/kind feature

@GLVSKiriti
Copy link
Contributor Author

GLVSKiriti commented Mar 23, 2024

I tested this event by enabling in rules file here. And on running event code a warning log is produced on left terminal as expected

readshellconfigfile

@GLVSKiriti
Copy link
Contributor Author

@FedeDP In this just created a unique temp directory as you said in one of previous PR's and finally created a .bashrc file in it and its enough to trigger the rule

tempDirectoryName, err := os.MkdirTemp("/", "created-by-event-generator-")
if err != nil {
return err
}
defer os.RemoveAll(tempDirectoryName)
filename := filepath.Join(tempDirectoryName, ".bashrc")
// os.Create is enough to trigger the rule
if _, err := os.Create(filename); err != nil {

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link

poiana commented Apr 3, 2024

LGTM label has been added.

Git tree hash: 2abcfb01159180bea7c57fe0950f63c84eb72053

@poiana
Copy link

poiana commented Apr 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, GLVSKiriti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the approved label Apr 3, 2024
@poiana poiana merged commit 5566085 into falcosecurity:main Apr 3, 2024
4 checks passed
@GLVSKiriti GLVSKiriti deleted the readShellConfiguratoonFile branch April 3, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants