generated from falcosecurity/template-repository
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding an event for disallowed_ssh_connection_non_standard_port #144
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
39 changes: 39 additions & 0 deletions
39
events/syscall/disallowed_ssh_connection_non_standard_port.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
// SPDX-License-Identifier: Apache-2.0 | ||
/* | ||
Copyright (C) 2024 The Falco Authors. | ||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
http://www.apache.org/licenses/LICENSE-2.0 | ||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
package syscall | ||
|
||
import ( | ||
"github.com/falcosecurity/event-generator/events" | ||
"os/exec" | ||
) | ||
|
||
var _ = events.Register(DisallowedSSHConnectionNonStandardPort) | ||
|
||
func DisallowedSSHConnectionNonStandardPort(h events.Helper) error { | ||
path, err := exec.LookPath("ssh") | ||
if err != nil { | ||
// If we don't have an SSH, just bail | ||
return &events.ErrSkipped{ | ||
Reason: "ssh utility not found in path", | ||
} | ||
} | ||
// non_standard_port : 443 | ||
cmd := exec.Command("timeout", "1s", path, "[email protected]", "-p", "443") | ||
err = cmd.Run() | ||
if err != nil { | ||
return err | ||
} | ||
return nil | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@h4l0gen
Generally speaking, it is good practice to use example domains.
Just a doubt: will it work with
localhost
as well? 🤔If so, it would be preferable, to avoid outbound traffic. Otherwise, it's ok as-is now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leogr let me check..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leogr Its not working on localhost :)
![image](https://private-user-images.githubusercontent.com/117383853/321855998-3c537532-f0a4-41e8-be41-143b202d3572.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU5OTU5MDcsIm5iZiI6MTcyNTk5NTYwNywicGF0aCI6Ii8xMTczODM4NTMvMzIxODU1OTk4LTNjNTM3NTMyLWYwYTQtNDFlOC1iZTQxLTE0M2IyMDJkMzU3Mi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwOTEwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDkxMFQxOTEzMjdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1iMmY5YmYyMTQzMTI0YWU0ZGFiMTA3OWI1ZmZiY2IzODE1ZDA2MGNmMTBiN2ExYjE2MjI5NWE5NTUxNTEzM2RlJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.wxsUw5Ssttjgbl7XHL1VlSaofIKdL9LMBHGTUMDTaFQ)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FedeDP what do you think about using
example.net
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
localhost
should work just fine; in your case it is not working because you are actually succeeding in logging in (ie: you have an ssh daemon on port 443(?))I'd try to connect to localhost to a different port, like 4444, and see if that triggers the rule.
See https://github.com/falcosecurity/rules/blob/main/rules/falco_rules.yaml#L1207 for the ports that can be used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uh nope, the rule triggers only for
outbound
connections, therefore it won't fire for localhost. See: https://github.com/falcosecurity/rules/blob/main/rules/falco_rules.yaml#L1223C5-L1223C13I guess it's ok then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, @FedeDP, if everything seems good, then we are good to proceed with this PR and this one?