Added an event for default rule "Detect crypto miners using the Stratum protocol" #173
Conversation
…m protocol Signed-off-by: GLVS Kiriti <[email protected]>
Signed-off-by: GLVS Kiriti <[email protected]>
|
As expected on executing event code it produces the critical priority log by triggering the rule on left terminal and test is also successful!
|
|
@FedeDP What is your feedback on this approach? 👀 |
| // minersoftware -o stratum+tcp://example.com:3333 -u username -p password | ||
| // However, for testing purposes, we're using 'ls' as a placeholder. | ||
| cmd := exec.Command("ls", "-o stratum+tcp", "-u user", "-p pass") | ||
| cmd.Run() |
There was a problem hiding this comment.
Wait, can we return cmd.Run instead of throwing its return error away?
There was a problem hiding this comment.
@FedeDP cmd := exec.Command("ls", "-o stratum+tcp", "-u user", "-p pass")
cmd.Run() always throws an error because this command fails every time.
If we return error then test wont pass due to error even still the rule triggers
There was a problem hiding this comment.
Irrespective of whether ls command fails or not the rule gets triggered. So there is no need to return the error
There was a problem hiding this comment.
Uh i see, you are right! Thank you!
|
LGTM label has been added. Git tree hash: cc42c71b6599b05933b0c355e9ace63cdc8bd25f
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, GLVSKiriti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area events
What this PR does / why we need it:
Added an event for default rule "Detect crypto miners using the Stratum protocol" as mentioned here
Which issue(s) this PR fixes:
Fixes #172
Special notes for your reviewer: