Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an event for default rule "Detect crypto miners using the Stratum protocol" #173

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions events/syscall/detect_crypto_miners_using_the_stratum_protocol.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
// SPDX-License-Identifier: Apache-2.0
/*
Copyright (C) 2024 The Falco Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package syscall

import (
"os/exec"

"github.com/falcosecurity/event-generator/events"
)

var _ = events.Register(
DetectCryptoMinersUsingTheStratumProtocol,
events.WithDisabled(), // this rules is not included in falco_rules.yaml (stable rules), so disable the action
)

func DetectCryptoMinersUsingTheStratumProtocol(h events.Helper) error {
// NOTE: Crypto mining commands typically may resemble the following format,
// where 'minersoftware' is an executable:
// minersoftware -o stratum+tcp://example.com:3333 -u username -p password
// However, for testing purposes, we're using 'ls' as a placeholder.
cmd := exec.Command("ls", "-o stratum+tcp", "-u user", "-p pass")
cmd.Run()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, can we return cmd.Run instead of throwing its return error away?

Copy link
Contributor Author

@GLVSKiriti GLVSKiriti Apr 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FedeDP cmd := exec.Command("ls", "-o stratum+tcp", "-u user", "-p pass")

cmd.Run() always throws an error because this command fails every time.

If we return error then test wont pass due to error even still the rule triggers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Irrespective of whether ls command fails or not the rule gets triggered. So there is no need to return the error

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh i see, you are right! Thank you!

return nil
}
Loading