Feature: Add support for testing falco rules using declarative YAML files in event-generator #211
Conversation
|
I'm encountering an issue with my YAML test configuration. When running the following single-test YAML file: tests:
- rule: WriteBelowRoot
runner: HostRunner
before: ""
steps:
- syscall: "write"
args:
filepath: "/root/created-by-event-generator"
content: ""
after: "rm -f /root/created-by-event-generator"The rule triggers and the test passes successfully, as shown in the screenshot below:
However, when I use a YAML file with multiple tests, like this: tests:
- rule: WriteBelowRoot
runner: HostRunner
before: ""
steps:
- syscall: "write"
args:
filepath: "/root/created-by-event-generator"
content: ""
after: "rm -f /root/created-by-event-generator"
- rule: WriteBelowEtc
runner: HostRunner
before: ""
steps:
- syscall: "write"
args:
filepath: "/etc/created-by-event-generator"
content: ""
after: "rm -f /etc/created-by-event-generator"The tests fail to pass, as shown in this screenshot: Individually, both tests pass, but they fail when combined in a single YAML file. What could be causing this issue? |
| // Yaml file structure | ||
| type SyscallStep struct { | ||
| Syscall string `yaml:"syscall"` | ||
| Args map[string]string `yaml:"args"` |
There was a problem hiding this comment.
Can we map all args values as strings?
GLVSKiriti
changed the title
There was a problem hiding this comment.
I left some suggestions.
Please use conventional commits and squash them.
- Added a new subcommand declarative for run command - Implemented parsing of YAML test files - Added HostRunner for executing tests on the host - Setup and Cleanup scripts execution - Steps execution for write syscall - Added detailed error handling and logging - Ensure continuation of test even if one fails - Added required helpers to test rule Write Below Root and Write Below Etc Signed-off-by: GLVS Kiriti <[email protected]>
GLVSKiriti
force-pushed
the
DeclarativeYamlSupport
branch
from
fbf1e9f
to
9ab3066
Compare
|
LGTM label has been added. Git tree hash: fc7e525e5f896819d08b4901e558b8e19a249163
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alacuku, FedeDP, GLVSKiriti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
What this PR does / why we need it:
This PR is to add support for testing falco rules using declarative YAML files in event-generator. The implementation idea is here
Which issue(s) this PR fixes:
Part of GSoC 2024 project "Falco: Upgrading event-generator and automating Falco performance testing"
falcosecurity/evolution#362
Special notes for your reviewer:
cc @jasondellaluce @alacuku