Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity Centre: insertion points to support non-default selection criteria for embedded centres upon run #2271

Open
4 tasks done
01es opened this issue Jun 11, 2024 · 0 comments · May be fixed by #2276
Open
4 tasks done

Comments

@01es
Copy link
Member

01es commented Jun 11, 2024

Description

Currently, when running Entity Centres, all insertion points with embedded Entity Centres, cances selection criteria values that might have been entered by the user. This behaviour ensures that all subordinate queries, run by such embedded Entity Centres, are aligned with the main Entity Centre and its selection criteria. Otherwise, it is very likely to create a situation where insertion points display an empty result or a subset of the data that does not fully align with the main result.

However, there are situations, such as in dashboards, which extensively utilise insertion points, there is no single "main" result. In other words, the embedded into the insertion points Entity Centres, are independent. In such situations running happens as the means for refreshing the data in those independent insertion points, which currently clears any selection criteria that users might have entered. This situation needs to be improved.

It is proposed to introduce a configuration parameter for insertion points (or embedded entity centres more generally) to:

  • 1. Skip clearing selection criteria for embedded Entity Centres during run.

  • 2. Keep the currently loaded save-as configuration, which should retain any unsaved modifications upon run.

In addition:

  • 3. Provide a visual cue by highlighting the filter action in blue (--paper-light-blue-600) in cases where changes to selection criteria were made, but not saved. This is to bring the user's attention to the fact that custom selection criteria are used. Such visual cue would be applied generically to embedded and standalone sentres, irrespective of whether it is configured to run automatically or not.

  • 4. Improve indication of the loaded save-as configurations for insertion points by showing the configuration title in the insertion point's title bar (in ()) - not the main application title bar as it happens for standalone centres.

Expected outcome

Ability to configure Entity Centres, embedded into insertion points, not to clear selection criteria when running.

jhou-pro added a commit that referenced this issue Jun 14, 2024
…re DSL that allows to customise auto-running behaviour. This option allows to preserve user criteria during auto-running of default configurations of such centres. This may be useful in insertion points with embedded centres, but also in compound master's embedded centres and even standalone auto-runnable centres.
01es added a commit that referenced this issue Jun 21, 2024
jhou-pro added a commit that referenced this issue Jun 26, 2024
…ntres with NO_CRITERIA_CLEARING option. This is to be inline with criteria preservation for default configurations.
jhou-pro added a commit that referenced this issue Jun 26, 2024
…embedded centres with NO_CRITERIA_CLEARING option (used preferred config concept). This is to be inline with criteria preservation for default configurations. This will take effect after application reload.
jhou-pro added a commit that referenced this issue Jul 11, 2024
…e may be altered. This was previously targeted for centreDirty. Avoided double calculation for centreChanged. Temporarily used centreChanged for SAVE button color for testing.
jhou-pro added a commit that referenced this issue Jul 11, 2024
… title bars and prevented propagation above to standalone centre title bar.
jhou-pro added a commit that referenced this issue Jul 11, 2024
…tre state may be altered. This was previously targeted for centreDirty. Avoided double calculation for centreChanged. Temporarily used centreChanged for SAVE button color for testing."

This reverts commit 4cff9be.
jhou-pro added a commit that referenced this issue Jul 11, 2024
…. Bound informational message to 'Show selection criteria' button (temporarily with same colour). Excluded non-criteria items from comparison.
jhou-pro added a commit that referenced this issue Jul 18, 2024
… adjustments of corresponding documentation. Fixed some jdoc references.
jhou-pro added a commit that referenced this issue Jul 18, 2024
…sed styles for Show Selection Criteria button. Handle not yet initialised CriteriaIndication properly.
jhou-pro added a commit that referenced this issue Jul 18, 2024
jhou-pro added a commit that referenced this issue Jul 18, 2024
@01es 01es added this to the 1.5.0 milestone Jul 18, 2024
jhou-pro added a commit that referenced this issue Jul 18, 2024
# Conflicts:
#	platform-web-resources/src/main/java/ua/com/fielden/platform/web/resources/webui/CriteriaResource.java
jhou-pro added a commit that referenced this issue Jul 19, 2024
jhou-pro added a commit that referenced this issue Jul 19, 2024
jhou-pro added a commit that referenced this issue Jul 20, 2024
…n state on SAVE button for save-as configs.
jhou-pro added a commit that referenced this issue Jul 20, 2024
jhou-pro added a commit that referenced this issue Aug 1, 2024
jhou-pro added a commit that referenced this issue Aug 1, 2024
…e saving action waiting on last validation attempt to be completed -- also similar as in Entity Masters. This corrects functioning of criteria indicator when immediate SAVE is occurring without explicit tab-off validation.
jhou-pro added a commit that referenced this issue Aug 1, 2024
…efault/non-link configurations. This brings performance for save-as / inherited configs as if no criteria indicator was calculated.
jhou-pro added a commit that referenced this issue Aug 2, 2024
# Conflicts:
#	platform-web-ui/src/main/web/ua/com/fielden/platform/web/centre/tg-entity-centre-insertion-point.js
#	platform-web-ui/src/main/web/ua/com/fielden/platform/web/centre/tg-entity-centre-template.js
#	platform-web-ui/src/main/web/ua/com/fielden/platform/web/centre/tg-entity-centre.js
jhou-pro added a commit that referenced this issue Aug 2, 2024
# Conflicts:
#	platform-web-ui/src/main/web/ua/com/fielden/platform/web/centre/tg-entity-centre-insertion-point.js
#	platform-web-ui/src/main/web/ua/com/fielden/platform/web/centre/tg-entity-centre-template.js
#	platform-web-ui/src/main/web/ua/com/fielden/platform/web/centre/tg-entity-centre.js
@01es 01es modified the milestones: 1.5.0, 1.6.0 Aug 6, 2024
jhou-pro added a commit that referenced this issue Aug 23, 2024
# Conflicts:
#	platform-web-ui/src/main/web/ua/com/fielden/platform/web/centre/tg-entity-centre-insertion-point.js
jhou-pro added a commit that referenced this issue Aug 23, 2024
# Conflicts:
#	platform-web-ui/src/main/web/ua/com/fielden/platform/web/centre/tg-entity-centre-insertion-point.js
jhou-pro added a commit that referenced this issue Aug 23, 2024
oleh-maikovych added a commit that referenced this issue Aug 26, 2024
…#2275

# Conflicts:
#	platform-web-ui/src/main/web/ua/com/fielden/platform/web/centre/tg-entity-centre-insertion-point.js
oleh-maikovych added a commit that referenced this issue Aug 27, 2024
…#2275

# Conflicts:
#	platform-web-ui/src/main/web/ua/com/fielden/platform/web/centre/tg-entity-centre-insertion-point.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment