-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #2271 - Entity Centre: insertion points to support non-default selection criteria for embedded centres upon run #2276
Open
jhou-pro
wants to merge
22
commits into
develop
Choose a base branch
from
Issue-#2271
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re DSL that allows to customise auto-running behaviour. This option allows to preserve user criteria during auto-running of default configurations of such centres. This may be useful in insertion points with embedded centres, but also in compound master's embedded centres and even standalone auto-runnable centres.
oleh-maikovych
approved these changes
Jun 19, 2024
01es
requested changes
Jun 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional changes are required as per updated issue #2271
…ntres with NO_CRITERIA_CLEARING option. This is to be inline with criteria preservation for default configurations.
…embedded centres with NO_CRITERIA_CLEARING option (used preferred config concept). This is to be inline with criteria preservation for default configurations. This will take effect after application reload.
…e may be altered. This was previously targeted for centreDirty. Avoided double calculation for centreChanged. Temporarily used centreChanged for SAVE button color for testing.
… title bars and prevented propagation above to standalone centre title bar.
…tre state may be altered. This was previously targeted for centreDirty. Avoided double calculation for centreChanged. Temporarily used centreChanged for SAVE button color for testing." This reverts commit 4cff9be.
…. Bound informational message to 'Show selection criteria' button (temporarily with same colour). Excluded non-criteria items from comparison.
… adjustments of corresponding documentation. Fixed some jdoc references.
…sed styles for Show Selection Criteria button. Handle not yet initialised CriteriaIndication properly.
# Conflicts: # platform-web-resources/src/main/java/ua/com/fielden/platform/web/resources/webui/CriteriaResource.java
* Improved selectionCriteriaEquals API to be more narrow to the needed usecase. * Extended javadoc for it. * Reduced code by using Objects.equals/hash methods. * Improved equals impl by checking getClass() earlier, as IntelliJ suggested. * Tightened up selectionCriteriaEquals for tickManagerAndEnhancer to check super equality.
…n state on SAVE button for save-as configs.
…teria clearing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #2271