Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update market SectorDealIDs type for transparent serialization. #238

Closed
wants to merge 1 commit into from
Closed

Update market SectorDealIDs type for transparent serialization. #238

wants to merge 1 commit into from

Conversation

anorth
Copy link
Member

@anorth anorth commented Jan 16, 2024

@anorth anorth marked this pull request as draft January 16, 2024 19:06
@anorth
Copy link
Member Author

anorth commented Jan 16, 2024

@magik6k please help me, I don't know how to get cbor-gen to accept this. I'm getting

panic: reflect: NumField of non-struct type []abi.DealID

goroutine 1 [running]:
reflect.(*rtype).NumField(0x0?)
	/opt/homebrew/Cellar/go/1.21.4/libexec/src/reflect/type.go:762 +0x6c
github.com/whyrusleeping/cbor-gen.ParseTypeInfo({0x1030851a0?, 0x140001b3138?})
	/Users/me/go/pkg/mod/github.com/whyrusleeping/[email protected]/gen.go:183 +0x100
github.com/whyrusleeping/cbor-gen.WriteTupleEncodersToFile({0x10300e3b6, 0x20}, {0x103004682, 0x6}, {0x140001b7158, 0x16, 0x0?})
	/Users/me/go/pkg/mod/github.com/whyrusleeping/[email protected]/writefile.go:21 +0xa0
main.main()
	/Users/me/pl/src/filecoin-project/go-state-types/builtin/v13/gen/gen.go:112 +0x1150
exit status 2
make: *** [gen] Error 1

@anorth anorth mentioned this pull request Jan 16, 2024
Merged
@magik6k
Copy link
Contributor

magik6k commented Jan 24, 2024

Done in 24c91c4
Required extending cbor-gen a little - whyrusleeping/cbor-gen#91

@magik6k magik6k closed this Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anorth @magik6k