-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transparent encoding #91
Conversation
Do we need the version that supports the
|
(basically, I'd consider just sticking with newtypes to avoid the bikeshed) |
Would be nice to see tests with pre-recorded forms rather than just roundtrips. I'd come up with some but I'm only on my phone at the moment. If you |
I’d say yes, this is the only way that makes it possible to do things like set array size limits and nil slice handling, which will inevitably be useful |
Ah, good point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks correct. I'd much prefer to find a way to split this out into multiple functions as I think someone will trip over this eventually, but I'm not the one writing the code so I'm not sure how much work that would be.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat, seems useful
This PR adds support for 'transparent' encoding, either in structs with
cborgen:"transparent"
tag (which can be used with other tags), or by just defining a newtype that isn't a structOpinions this is based on: