-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TASK: Move imageOptions to configuration #14
TASK: Move imageOptions to configuration #14
Conversation
Talking to @kdambekalns about confirmation of the "concept". Alternative: Remove the "height" property from the current imageOptions, to have the preview images in the media browser not cropped, so the editor can see if they are vertical or horizontal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good, I'll test this ASAP.
@kdambekalns I will suggest that we use keys for the different sizes - that way, it's easier to override the imageOptions for a specific case. Do you agree on that thought? |
@kdambekalns Named configurations with preset fallback is ready for review |
@kdambekalns Anything missing for a merge and release? |
Mmm, I feel this should be a major version due to the fact the configuration has changed? @sorenmalling @kdambekalns |
In fact the configuration does what was hardcoded before – except the cropping for the thumbnails. So I'd say this can go into a minor… |
Resolves #17