Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Move imageOptions to configuration #14

Merged

Conversation

sorenmalling
Copy link
Contributor

@sorenmalling sorenmalling commented May 11, 2022

Resolves #17

@sorenmalling
Copy link
Contributor Author

Talking to @kdambekalns about confirmation of the "concept".

Alternative: Remove the "height" property from the current imageOptions, to have the preview images in the media browser not cropped, so the editor can see if they are vertical or horizontal

Copy link
Member

@kdambekalns kdambekalns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good, I'll test this ASAP.

@sorenmalling
Copy link
Contributor Author

@kdambekalns I will suggest that we use keys for the different sizes - that way, it's easier to override the imageOptions for a specific case. Do you agree on that thought?

@sorenmalling sorenmalling marked this pull request as ready for review June 7, 2022 08:41
@sorenmalling
Copy link
Contributor Author

@kdambekalns Named configurations with preset fallback is ready for review

@sorenmalling
Copy link
Contributor Author

@kdambekalns Anything missing for a merge and release?

@kitsunet
Copy link
Member

Mmm, I feel this should be a major version due to the fact the configuration has changed? @sorenmalling @kdambekalns

@kdambekalns
Copy link
Member

Mmm, I feel this should be a major version due to the fact the configuration has changed?

In fact the configuration does what was hardcoded before – except the cropping for the thumbnails. So I'd say this can go into a minor…

@kdambekalns kdambekalns merged commit 11dcf30 into flownative:main Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Imagesizeoptions can not be modified
3 participants