Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Ensure initialized account before creating client secret lookup #15

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

sorenmalling
Copy link
Contributor

@sorenmalling sorenmalling commented Jun 7, 2022

In a combination with a custom ThumbnailGenerator from the Sitegeist.AssetSource.3QVideo package (https://github.com/sitegeist/Sitegeist.AssetSource.3QVideo/blob/main/Classes/Domain/ThumbnailGenerator.php) there is no Account in the security context, when going through the ThumbnailStrategies on a media/thumbnail/<uuid> url.

This change adds a check for a actual account, before trying to fetch a client secret

Resolves #16

@sorenmalling
Copy link
Contributor Author

ping @mficzel

@sorenmalling
Copy link
Contributor Author

Disclaimer: There is a posibility of this being a bug in the Media module. The tokens are "gone" in between the initialize and isInitialized call, when this Pixx.io, does the check, where I added the extra condition.
Me and @mficzel are curious to find out how/what/where/why this happens. We both believe that there can be a different solution that this, that is more focused on a core issue.

Copy link
Member

@kitsunet kitsunet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to prevent errors here even if in a "default" use case it should have an account.

@sorenmalling
Copy link
Contributor Author

@kitsunet Will you take care of merging and create a release together with #14 ? :)

@kitsunet kitsunet merged commit 1b5a49b into flownative:main Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not always a account present when initializing a client
3 participants