-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use shared workflows #49
Conversation
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
@aalur @ani1311 @wiardvanrij the tests are failing (even without any of these changes) : $ go test ./...
--- FAIL: TestApp_singleBurst_Success (0.00s)
app_test.go:66: Expected processQueue finish the job in ~9 seconds, give or take. Got 7.0958e-05
--- FAIL: TestApp_MultiBurst_Success (0.00s)
app_test.go:109: Expected processQueue finish the job in ~9 seconds, give or take. Got 3.9959e-05
--- FAIL: TestApp_TestSlackRequestRate (0.00s)
app_test.go:152: Expected processQueue finish the job in ~5 seconds, give or take. Got 1.7708e-05
{"ts":1710991346.114238,"level":"err","r":54,"file":"main_test.go","line":20,"msg":"Testing logging - err","err":"Channel is not set and Neither attachments, blocks, nor text is set"}
{"ts":1710991346.114729,"level":"err","r":87,"file":"server.go","line":81,"msg":"Invalid request","err":"Channel is not set and Neither attachments, blocks, nor text is set"}
FAIL
FAIL fortio.org/slack-proxy 2.166s
FAIL I'll see if I can find a way to either customize the golangci or write a tool to fix all the
|
Started on lll fixer at ldemailly/lll-fixer#1 |
to use a shorter len and version that handles litterals This reverts commit 8b54291.
all |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
==========================================
+ Coverage 46.78% 46.94% +0.16%
==========================================
Files 4 4
Lines 404 426 +22
==========================================
+ Hits 189 200 +11
- Misses 206 217 +11
Partials 9 9 ☔ View full report in Codecov by Sentry. |
use https://github.com/fortio/workflows
like fortio/logc#44