Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial / start of implementation #1

Merged
merged 17 commits into from
Mar 23, 2024
Merged

Initial / start of implementation #1

merged 17 commits into from
Mar 23, 2024

Conversation

ldemailly
Copy link
Owner

@ldemailly ldemailly commented Mar 21, 2024

  • basic structure
  • fix issue with leading whitespace in (split) comments
  • handle in place changes (rename original to .bak) as well as gofumpt
  • better/smart (word) cut for comments
  • handle /* and not just //
  • issue with disappearing new line before function after */ (see make test) go/ast,go/format: newline missing between modified comment and function golang/go#66439
  • handle comments not just at top level
  • handle string literals (which is most of the issues in Use shared workflows fortio/slack-proxy#49)
  • handle that a literal or comment maybe below the -len yet making a line in total > len (because of right indentation)
  • cut more lines like function signatures

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@ldemailly ldemailly changed the title Initial / start of implementation, already showing an odd bug Initial / start of implementation Mar 21, 2024
Copy link

codecov bot commented Mar 21, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@ldemailly
Copy link
Owner Author

will merge this as a good enough starting point and make follow up issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant