feat: split off binding generation from foundry-evm #4935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
May 13, 2023
| /// Includes a JSON ABI as a string literal. | ||
| macro_rules! include_json_abi { | ||
| ($path:literal) => {{ | ||
| println!(concat!("cargo:rerun-if-changed=", $path)); |
Yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#4928
cargo c -p foundry-evmfrom ~5s to ~0.5sUnfortunately rust-analyzer is still slow-ish because it has to check other crates in the workspace which depend on it, eg
anvilandfoundry-cli, so this gain isn't that drastic, but definitely noticeable, I'd say about 50% faster.Also includes some work on removing ethers-solc from the dependencies.
Solution