Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move formatting logic to foundry-macros #4936

Merged
merged 2 commits into from
May 13, 2023
Merged

chore: move formatting logic to foundry-macros #4936

merged 2 commits into from
May 13, 2023

Conversation

DaniPopes
Copy link
Member

Motivation

foundry-macros depends on foundry-config for just the UIFmt trait, thus any user of the simple macro crate would have hundreds of other unrelated dependencies.

Part of #4928, helps with #4935

Solution

mattsse
mattsse approved these changes May 13, 2023
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets go

@mattsse mattsse merged commit 56e8da4 into foundry-rs:master May 13, 2023
@DaniPopes DaniPopes deleted the chore/uifmt branch May 13, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DaniPopes @mattsse