This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
More changes related to latest janus 0.10.x #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentfretin
force-pushed
the
feature/api-v15
branch
from
0bb1d62
to
ef91198
Compare
|
Yes, it's working, I successfully updated the janus-plugin-sfu with those changes. Feel free to merge this in your branch. |
|
@vincentfretin since mozilla#24 has been merged I think it'd be better if you rebase the branch from the upstream's master and send a PR there. |
This was referenced Jan 25, 2021
|
Hey, this is done! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to update janus-plugin-sfu mozilla/janus-plugin-sfu#58 to latest janus.
I'm just opening a Draft PR from your branch to let you know. My changes here may not be correct, that's why it's draft.