Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest janus 0.10.x (api v15) #61

Merged
merged 2 commits into from
Jan 25, 2021

Conversation

vincentfretin
Copy link
Contributor

See discussion on #58
I started from @feymartynov work and made additional changes in janus-plugin-rs foxford/janus-plugin-rs#1
The code compile but not currently fully working, I still have an issue generating the sdp offer based on the sdp answer where answer.get_payload_type(VIDEO_CODEC.to_cstr()) is returning None.

@vincentfretin
Copy link
Contributor Author

I may or may not continue working on it. See #62
I 'm really thinking about switching to another stack for my project :D
Anyway it was fun to work on it. I learned a lot.

@vincentfretin
Copy link
Contributor Author

Yes, I got this working.
We need to specify the h264 42e01f profile when creating the answer and offer, this was previously done by default because h264_fmtp was true by default.

@vincentfretin vincentfretin marked this pull request as ready for review January 23, 2021 12:35
@vincentfretin
Copy link
Contributor Author

I tested this with
ubuntu 18.04
janus-gateway 2021-01-21 13:02 46a6c71b0fb7e54cb9acfbec84391c75eb224c13 (post v0.10.9)
libnice Jan 6, 2021 2b38ba23b726694293de53c90b59b28ca11746ab (post 0.1.18)
usrsctp Jan 13, 2021 0.9.5.0 07f871bda23943c43c9e74cc54f25130459de830
libsrtp 2.3.0
libwebsockets 3.2.3

@vincentfretin
Copy link
Contributor Author

This needs PR foxford/janus-plugin-rs#1 of janus-plugin-rs.

@vincentfretin
Copy link
Contributor Author

@mqp I did again my janus-plugin-rs PR against mozilla repo mozilla/janus-plugin-rs#26 now you merged @feymartynov PR mozilla/janus-plugin-rs#24

@mqp
Copy link
Contributor

mqp commented Jan 25, 2021

Looks good -- now that I merged the corresponding janus-plugin-rs changes, I'll merge this and then point Cargo.toml back at the upstream repo.

@mqp mqp merged commit a1e7578 into mozilla:master Jan 25, 2021
@vincentfretin
Copy link
Contributor Author

For those following the repo. You should now use at least
janus-gateway 2021-02-08 10:37 7732127f71521d1f1b305fdcf1073b3602f15b6e (v0.10.10)
that include a fix for future Chrome 90 for the sdp offer h264 profile parsing. Otherwise the screen share may stop working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants