refactor: download Sentry CLI at runtime #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaind
requested review from
marandaneto,
brustolin and
philipphofmann
as code owners
Merged
marandaneto
reviewed
Oct 6, 2022
marandaneto
reviewed
Oct 6, 2022
Co-authored-by: Manoel Aranda Neto <[email protected]>
marandaneto
reviewed
Oct 6, 2022
|
@denrase, we could use a similar approach for the sentry-fastlane-plugin ⬆️ |
|
Related to getsentry/sentry-fastlane-plugin#165. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Instead of expecting the sentry-cli to be shipped through pub.dev, downloads it at first run and checks the checksum (every run - it's quite quick though)
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
🔮 Next steps
auto-update: #50