-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove sentry-cli
from the repository
#165
Comments
@bruno-garcia I could take over this issue if you don't have anyone else in mind already. |
Please take it @denrase. |
Maybe we could apply a similar approach as we do in getsentry/sentry-dart-plugin#49. |
We've agreed that downloading on the fly is actually an improvement since you don't bloat the repo and the user has to download only the needed binary, although, if it's working and it's not a source of complaints, we can prioritize more important issues, and this is eventually done when there are no more p1 for example. |
I agree with lowering the priority for this issue. |
The idea is to download when packaging. Downloading on the user's machine has the downside of slowing down the first build,. Requiring internet access on the build time as opposed to "restore deps" phase; and brings security concerns (unless we pin ssl cert, which isn't good to maintain). So the trade off is to check in the Sha in the repo and in CI when packaging, download the binary and verify the checksum. The final artifact will bundle it. |
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
In this PR we've added more archictecutre/platform supports for sentry-cli:
This will eventually bloat the repository significantly with the updates.
Proposed solution
Download sentry-cli on the first build. Check the checksum of the downloaded version against the checksum stored in the repo.
The text was updated successfully, but these errors were encountered: