better log2 doc #22191
Merged
better log2 doc #22191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakevdp
reviewed
Jun 28, 2024
|
Thanks! If you can squash the changes into a single commit, then we'll get this merged. |
dfm
requested changes
Jul 1, 2024
jax/_src/numpy/ufuncs.py
Outdated
Comment on lines
848
to
850
| >>> x2 = jnp.array([-0.25, -0.5, -1, -2, -4, -8]) | ||
| >>> jnp.log2(x2) | ||
| Array([nan, nan, nan, nan, nan, nan], dtype=float32) |
There was a problem hiding this comment.
I'm not sure that this example really adds much to the discussion. I'd recommend that we remove it!
removing complex example removing negative example
google-ml-butler
bot
added
kokoro:force-run
pull ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
better log2 doc
Part of #21461