better log10 doc #22192
Open
better log10 doc #22192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakevdp
reviewed
Jun 28, 2024
jax/_src/numpy/ufuncs.py
Outdated
| Examples: | ||
| >>> x1 = jnp.array([0.01, 0.1, 1, 10, 100, 1000]) | ||
| >>> jnp.log10(x1) | ||
| Array([-1.9999999 , -0.99999994, 0. , 0.99999994, 1.9999999 , |
There was a problem hiding this comment.
Floating point outputs like this are problematic for doctests, because different backends may round results differently. One way to deal with this is to print the values within a jnp.printoptions context; you can check out some examples in jax/_src/numpy.lax_numpy.py
dfm
requested changes
Jul 1, 2024
jax/_src/numpy/ufuncs.py
Outdated
Comment on lines
856
to
858
| >>> x2 = jnp.array([-0.01, -0.1, -1, -10, -100, -1000]) | ||
| >>> jnp.log10(x2) | ||
| Array([nan, nan, nan, nan, nan, nan], dtype=float32) |
There was a problem hiding this comment.
Like in #22191, I think we should skip this example with negative numbers.
removing complex example forced precision context to work better with doctests removing negative example
pkgoogle
force-pushed
the
better_log10_doc
branch
from
df18677
to
13f2587
Compare
google-ml-butler
bot
added
kokoro:force-run
pull ready
|
@pkgoogle — It looks like the merge of this one collided with the log2 PR. Would you mind rebasing your branch onto the current jax |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
better log10 doc
Part of #21461