Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(daffio): update named views to specify sidebar header, content, and footer separately, and update usages #2724

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Jan 17, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Sidebar header and footer is set in the viewport template, but it should be dynamic.

Fixes: N/A

What is the new behavior?

  • Named views enums updated to: sidebar-header, sidebar-content, and sidebar-footer
  • Add named view service so named views can be hidden if not in use
  • Update usages

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@xelaint xelaint added package: daff.io @daffodil/daff.io status: awaiting review This PR is awaiting review labels Jan 17, 2024
@xelaint xelaint added this to the Daffodil v1.0 milestone Jan 17, 2024
@xelaint xelaint requested review from a team as code owners January 17, 2024 15:47
@xelaint xelaint added the package: router @daffodil/router label Jan 19, 2024
@griest024 griest024 added status: awaiting merge This PR has met all the requirements for merge and is waiting on an admin and removed status: awaiting review This PR is awaiting review labels Jan 19, 2024
@griest024 griest024 assigned xelaint and unassigned griest024 Jan 19, 2024
@xelaint xelaint merged commit 891a730 into develop Jan 19, 2024
9 checks passed
@gray-bot gray-bot mentioned this pull request Jan 19, 2024
@damienwebdev damienwebdev deleted the router-named-views-update branch June 13, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: daff.io @daffodil/daff.io package: router @daffodil/router status: awaiting merge This PR has met all the requirements for merge and is waiting on an admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants