Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(daffio): create separate footer for docs and add footer to named views enum #2733

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Jan 19, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

The sub footer and simple footer is used on both the marketing and docs pages. It's not necessary to show all of that information on the docs pages.

Depends on: #2724

What is the new behavior?

Create new footers for marketing and docs. Add footer to the router named view.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@xelaint xelaint added package: daff.io @daffodil/daff.io status: blocked This PR or issue is blocked and cannot currently be progressed package: router @daffodil/router labels Jan 19, 2024
@xelaint xelaint added this to the Daffodil v1.0 milestone Jan 19, 2024
@xelaint xelaint self-assigned this Jan 19, 2024
@xelaint xelaint requested review from a team as code owners January 19, 2024 14:45
@xelaint xelaint merged commit cfc2802 into develop Jan 22, 2024
8 checks passed
@gray-bot gray-bot mentioned this pull request Jan 22, 2024
@xelaint xelaint deleted the footer-named-view branch March 13, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: daff.io @daffodil/daff.io package: router @daffodil/router status: blocked This PR or issue is blocked and cannot currently be progressed
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant