-
-
Notifications
You must be signed in to change notification settings - Fork 964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terragrunt performance improvements #3307
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Great Job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! I left some comments, what to do with them is up to you.
Quality Gate passedIssues Measures |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [gruntwork-io/terragrunt](https://github.com/gruntwork-io/terragrunt) | patch | `v0.66.1` -> `v0.66.3` | | [gruntwork-io/terragrunt](https://github.com/gruntwork-io/terragrunt) | patch | `0.66.1` -> `0.66.3` | --- ### Release Notes <details> <summary>gruntwork-io/terragrunt (gruntwork-io/terragrunt)</summary> ### [`v0.66.3`](https://github.com/gruntwork-io/terragrunt/releases/tag/v0.66.3) [Compare Source](https://github.com/gruntwork-io/terragrunt/compare/v0.66.2...v0.66.3) #### Updated CLI args, config attributes and blocks - `dependency` - `get_repo_root` #### Description - Improved efficiency in evaluating dependencies and locating the git repository root. #### Related links - [gruntwork-io/terragrunt#3307 **Full Changelog**: gruntwork-io/terragrunt@v0.66.2...v0.66.3 ### [`v0.66.2`](https://github.com/gruntwork-io/terragrunt/releases/tag/v0.66.2) [Compare Source](https://github.com/gruntwork-io/terragrunt/compare/v0.66.1...v0.66.2) #### What's Changed - fix: Reference OpenTofu Everywhere We Can by [@​yhakbar](https://github.com/yhakbar) in [gruntwork-io/terragrunt#3319 - add env TERRAGRUNT_EXCLUDE_DIR to docs by [@​pbrogan12](https://github.com/pbrogan12) in [gruntwork-io/terragrunt#3320 - build(deps-dev): bump nokogiri from 1.16.3 to 1.16.5 in /docs by [@​dependabot](https://github.com/dependabot) in [gruntwork-io/terragrunt#3135 - build(deps-dev): bump rexml from 3.3.1 to 3.3.3 in /docs by [@​dependabot](https://github.com/dependabot) in [gruntwork-io/terragrunt#3316 - feat: Adding `TG_CTX_TF_PATH` to hook context by [@​yhakbar](https://github.com/yhakbar) in [gruntwork-io/terragrunt#3323 #### New Contributors - [@​pbrogan12](https://github.com/pbrogan12) made their first contribution in [gruntwork-io/terragrunt#3320 **Full Changelog**: gruntwork-io/terragrunt@v0.66.1...v0.66.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/akrantz01/homelab). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xOC4xNyIsInVwZGF0ZWRJblZlciI6IjM4LjE4LjE3IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Previously when using the PartialConfig cache, the previous entries were modified after they'd been added to the cache. This was causing modules to inherit any dependencies if they were included in other modules, which in turn caused circular depedency issues. This ensures the cache is cloned when it is read using logic similar to gruntwork-io#3307
Previously when using the PartialConfig cache, the previous entries were modified after they'd been added to the cache. This was causing modules to inherit any dependencies if they were included in other modules, which in turn caused circular depedency issues. This ensures the cache is cloned when it is read using logic similar to gruntwork-io#3307
Description
A couple of performance improvements by using in-memory cache of git execution and parsing of dependencies
Example runs on my test repos:
Included changes:
git --show-toplevel
Close: #2344
References: #2980
TODOs
Read the Gruntwork contribution guidelines.
Release Notes (draft)
Added / Removed / Updated [X].
Migration Guide