feat: Adding strict lint #3348
Merged
feat: Adding strict lint #3348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
denis256
approved these changes
Aug 22, 2024
levkohimins
approved these changes
Aug 22, 2024
akrantz01
pushed a commit
to akrantz01/homelab
that referenced
this pull request
Aug 28, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [gruntwork-io/terragrunt](https://github.com/gruntwork-io/terragrunt) | minor | `v0.66.9` -> `v0.67.0` | | [gruntwork-io/terragrunt](https://github.com/gruntwork-io/terragrunt) | minor | `0.66.9` -> `0.67.0` | --- ### Release Notes <details> <summary>gruntwork-io/terragrunt (gruntwork-io/terragrunt)</summary> ### [`v0.67.0`](https://github.com/gruntwork-io/terragrunt/releases/tag/v0.67.0) [Compare Source](https://github.com/gruntwork-io/terragrunt/compare/v0.66.9...v0.67.0) #### Updated CLI args, config attributes and blocks - `--terragrunt-forward-tf-stdout` ([docs](https://terragrunt.gruntwork.io/docs/reference/cli-options/#terragrunt-forward-tf-stdout)) - `--terragrunt-disable-log-formatting` ([docs](https://terragrunt.gruntwork.io/docs/reference/cli-options/#terragrunt-disable-log-formatting)) #### Breaking Changes - [--terragrunt-include-module-prefix](https://terragrunt.gruntwork.io/docs/reference/cli-options/#terragrunt-include-module-prefix) flag is deprecated, use [--terragrunt-forward-tf-stdout](https://terragrunt.gruntwork.io/docs/reference/cli-options/#terragrunt-forward-tf-stdout) instead #### What's Changed - feat: Adding `wsl` lint by [@​yhakbar](https://github.com/yhakbar) in [gruntwork-io/terragrunt#3351 - feat: Engine documentation update by [@​denis256](https://github.com/denis256) in [gruntwork-io/terragrunt#3355 - feat: Adding strict lint by [@​yhakbar](https://github.com/yhakbar) in [gruntwork-io/terragrunt#3348 - feat: Split out unessential jobs by [@​yhakbar](https://github.com/yhakbar) in [gruntwork-io/terragrunt#3357 - feat: Adding `thelpher` and `wastedassign` lints by [@​yhakbar](https://github.com/yhakbar) in [gruntwork-io/terragrunt#3352 - fix: Updating docs 'Reading from other HCL files' by [@​riccalioliojr](https://github.com/riccalioliojr) in [gruntwork-io/terragrunt#3361 - feat: Log improvements by [@​levkohimins](https://github.com/levkohimins) in [gruntwork-io/terragrunt#3338 Old Terragrunt log:  New Terragrunt log:  #### New Contributors - [@​riccalioliojr](https://github.com/riccalioliojr) made their first contribution in [gruntwork-io/terragrunt#3361 **Full Changelog**: gruntwork-io/terragrunt@v0.66.9...v0.67.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/akrantz01/homelab). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds strict linting for pull requests. This ensures that new code being introduced adheres to improved code quality standards.
The two lints being added here are for
styleandcomplexity. The current codebase violates these rules basically everywhere, so it's not feasible to enable these lints for everything.Instead, we'll enable these lints for all new code being introduced or edited in pull requests, which should help us gradually improve the code quality over time.
I think if we're OK with introducing this, we should selectively ignore rules when they are too strict for a given file or require too much refactoring.
For a sense of the kinds of things we would change, you can take a look at this in-draft PR that I closed because it was unreasonably large:
#3347
TODOs
Read the Gruntwork contribution guidelines.
Release Notes (draft)
Added strict lint rules.