Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding wsl lint #3351

Merged
merged 2 commits into from
Aug 21, 2024
Merged

feat: Adding wsl lint #3351

merged 2 commits into from
Aug 21, 2024

Conversation

yhakbar
Copy link
Collaborator

@yhakbar yhakbar commented Aug 20, 2024

Description

Adds wsl to the list of lints. This ensures that there's proper spacing in the codebase.

There are parts of the codebase that have become a lot more legible as a consequence.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added wsl lints.

Copy link

sonarcloud bot commented Aug 20, 2024

Copy link
Contributor

@levkohimins levkohimins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@yhakbar
Copy link
Collaborator Author

yhakbar commented Aug 21, 2024

Perfect!

@levkohimins
Did you accidentally request changes? 😄

@levkohimins levkohimins self-requested a review August 21, 2024 11:55
@levkohimins
Copy link
Contributor

Perfect!

@levkohimins Did you accidentally request changes? 😄

Oh, yes, I did it accidentally, sorry :)

@yhakbar yhakbar merged commit 8d3e0c1 into master Aug 21, 2024
4 checks passed
@yhakbar yhakbar deleted the feat/adding-wsl-lint branch August 21, 2024 12:16
akrantz01 pushed a commit to akrantz01/homelab that referenced this pull request Aug 28, 2024
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[gruntwork-io/terragrunt](https://github.com/gruntwork-io/terragrunt)
| minor | `v0.66.9` -> `v0.67.0` |
|
[gruntwork-io/terragrunt](https://github.com/gruntwork-io/terragrunt)
| minor | `0.66.9` -> `0.67.0` |

---

### Release Notes

<details>
<summary>gruntwork-io/terragrunt (gruntwork-io/terragrunt)</summary>

###
[`v0.67.0`](https://github.com/gruntwork-io/terragrunt/releases/tag/v0.67.0)

[Compare
Source](https://github.com/gruntwork-io/terragrunt/compare/v0.66.9...v0.67.0)

#### Updated CLI args, config attributes and blocks

- `--terragrunt-forward-tf-stdout`
([docs](https://terragrunt.gruntwork.io/docs/reference/cli-options/#terragrunt-forward-tf-stdout))
- `--terragrunt-disable-log-formatting`
([docs](https://terragrunt.gruntwork.io/docs/reference/cli-options/#terragrunt-disable-log-formatting))

#### Breaking Changes

-
[--terragrunt-include-module-prefix](https://terragrunt.gruntwork.io/docs/reference/cli-options/#terragrunt-include-module-prefix)
flag is deprecated, use
[--terragrunt-forward-tf-stdout](https://terragrunt.gruntwork.io/docs/reference/cli-options/#terragrunt-forward-tf-stdout)
instead

#### What's Changed

- feat: Adding `wsl` lint by
[@&#8203;yhakbar](https://github.com/yhakbar) in
[gruntwork-io/terragrunt#3351
- feat: Engine documentation update by
[@&#8203;denis256](https://github.com/denis256) in
[gruntwork-io/terragrunt#3355
- feat: Adding strict lint by
[@&#8203;yhakbar](https://github.com/yhakbar) in
[gruntwork-io/terragrunt#3348
- feat: Split out unessential jobs by
[@&#8203;yhakbar](https://github.com/yhakbar) in
[gruntwork-io/terragrunt#3357
- feat: Adding `thelpher` and `wastedassign` lints by
[@&#8203;yhakbar](https://github.com/yhakbar) in
[gruntwork-io/terragrunt#3352
- fix: Updating docs 'Reading from other HCL files' by
[@&#8203;riccalioliojr](https://github.com/riccalioliojr) in
[gruntwork-io/terragrunt#3361
- feat: Log improvements by
[@&#8203;levkohimins](https://github.com/levkohimins) in
[gruntwork-io/terragrunt#3338

Old Terragrunt log:

![old-logs](https://github.com/user-attachments/assets/3cd5b8b1-ffe9-4002-a288-6ab333b6c174)

New Terragrunt log:

![new-logs](https://github.com/user-attachments/assets/0d30fd20-0360-47e2-9f5e-1db9f62d22d6)

#### New Contributors

- [@&#8203;riccalioliojr](https://github.com/riccalioliojr) made their
first contribution in
[gruntwork-io/terragrunt#3361

**Full Changelog**:
gruntwork-io/terragrunt@v0.66.9...v0.67.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/akrantz01/homelab).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants