Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot override TaskbarIcon.Dispose(bool) because it is not overridable #91

Closed
jhinder opened this issue Jan 26, 2023 · 0 comments · Fixed by #93
Closed

Cannot override TaskbarIcon.Dispose(bool) because it is not overridable #91

jhinder opened this issue Jan 26, 2023 · 0 comments · Fixed by #93
Labels
Bug Bug or Bug fixes
Milestone
2.0.0

Comments

@jhinder
Copy link

jhinder commented Jan 26, 2023

The documentation of TaskbarIcon.Dispose() says this:

This method is not virtual by design. Derived classes should override <see cref="Dispose(bool)"/>.

However it is impossible to actually override Dispose(bool) because it is a) private and b) not virtual.

Version: 1.1.0
jhinder pushed a commit to jhinder/wpf-notifyicon that referenced this issue Jan 30, 2023
@mm-jhn
hardcodet#91: Make TaskbarIcon.Dispose overridable
0a2b68e
@jhinder jhinder mentioned this issue Jan 30, 2023
Merged
@punker76 punker76 added the Bug Bug or Bug fixes label Aug 5, 2024
@punker76 punker76 added this to the 2.0.0 milestone Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Bug or Bug fixes
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Improve TaskbarIcon.Dispose jhinder/wpf-notifyicon
2 participants
@punker76 @jhinder