Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Security upgrade @hashgraph/hethers from 1.1.3 to 1.1.4 #1520

Merged
merged 6 commits into from
Jul 25, 2023

Conversation

swirlds-automation
Copy link
Contributor

This PR was automatically created by Snyk using the credentials of a real user.


Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • tools/web3js-example/package.json
    • tools/web3js-example/package-lock.json

Vulnerabilities that will be fixed

With an upgrade:
Severity Priority Score (*) Issue Breaking Change Exploit Maturity
high severity 823/1000
Why? Proof of Concept exploit, Recently disclosed, Has a fix available, CVSS 8.6
Prototype Pollution
SNYK-JS-PROTOBUFJS-5756498
No Proof of Concept

(*) Note that the real score may have changed since the PR was raised.

Commit messages
Package name: @hashgraph/hethers The new version differs by 5 commits.

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Prototype Pollution

@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ae7636a) 78.24% compared to head (c76b597) 78.24%.

❗ Current head c76b597 differs from pull request most recent head 31dc751. Consider uploading reports for the commit 31dc751 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1520   +/-   ##
=======================================
  Coverage   78.24%   78.24%           
=======================================
  Files          32       32           
  Lines        2625     2625           
  Branches      544      544           
=======================================
  Hits         2054     2054           
  Misses        405      405           
  Partials      166      166           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ebadiere
ebadiere previously approved these changes Jul 17, 2023
Copy link
Collaborator

@ebadiere ebadiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG.

…-lock.json to reduce vulnerabilities

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-PROTOBUFJS-5756498

Signed-off-by: ebadiere <[email protected]>
@ebadiere ebadiere force-pushed the snyk-fix-9bcf504af3c2f9ce2fc4a5e749b3370a branch from 52e8103 to 6fcb2a4 Compare July 18, 2023 21:23
Signed-off-by: ebadiere <[email protected]>
@ebadiere ebadiere force-pushed the snyk-fix-9bcf504af3c2f9ce2fc4a5e749b3370a branch from d43ca5b to fc3babc Compare July 19, 2023 14:56
@sonarcloud
Copy link

sonarcloud bot commented Jul 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@ebadiere ebadiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG.

@ebadiere ebadiere merged commit 67bc946 into main Jul 25, 2023
24 checks passed
@ebadiere ebadiere deleted the snyk-fix-9bcf504af3c2f9ce2fc4a5e749b3370a branch July 25, 2023 15:21
mshakeg pushed a commit to mshakeg/hedera-json-rpc-relay that referenced this pull request Oct 18, 2023
…raph#1520)

* fix: tools/web3js-example/package.json & tools/web3js-example/package-lock.json to reduce vulnerabilities

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-PROTOBUFJS-5756498

Signed-off-by: ebadiere <[email protected]>

* Fixed snyk errors.

Signed-off-by: ebadiere <[email protected]>

* Ignore as hethers will be removed.

Signed-off-by: ebadiere <[email protected]>

---------

Signed-off-by: ebadiere <[email protected]>
Co-authored-by: snyk-bot <[email protected]>
Co-authored-by: ebadiere <[email protected]>
Signed-off-by: Mo Shaikjee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants