Fix nonce zerohexbytes regression #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #260 +/- ##
=======================================
Coverage 58.35% 58.35%
=======================================
Files 9 9
Lines 742 742
Branches 111 111
=======================================
Hits 433 433
Misses 283 283
Partials 26 26
Continue to review full report at Codecov.
|
shemnon
previously approved these changes
Jun 23, 2022
Signed-off-by: Nana-EC <[email protected]>
Signed-off-by: Nana-EC <[email protected]>
Nana-EC
force-pushed
the
149-fix-regerssion
branch
from
78fd7a2
to
1dcfcb4
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
shemnon
approved these changes
Jun 23, 2022
Nana-EC
added a commit
that referenced
this pull request
Jun 23, 2022
* Fix nonce zerohexbytes regression There was a regression that lost the use of the `EthImpl.zeroHex8Byte` Restore this - Update `eth.ts` to use `EthImpl.zeroHex8Byte` - Update `eth.spec.ts` to use `EthImpl.zeroHex8Byte` Signed-off-by: Nana-EC <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nana-EC [email protected]
Description:
There was a regression that lost the use of the
EthImpl.zeroHex8ByteRestore this
eth.tsto useEthImpl.zeroHex8Byteeth.spec.tsto useEthImpl.zeroHex8ByteRelated issue(s):
Fixes #149
Notes for reviewer:
Checklist