Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align log with execution apis #343

Merged
merged 3 commits into from
Jul 20, 2022
Merged

Conversation

natanasow
Copy link
Collaborator

@natanasow natanasow commented Jul 19, 2022

Signed-off-by: nikolay [email protected]

Description:

Related issue(s):

Fixes #337

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@natanasow natanasow marked this pull request as draft July 19, 2022 07:02
@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2022

Codecov Report

Merging #343 (e0e501b) into main (bbc34c6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #343   +/-   ##
=======================================
  Coverage   62.29%   62.29%           
=======================================
  Files           9        9           
  Lines         870      870           
  Branches      142      142           
=======================================
  Hits          542      542           
  Misses        290      290           
  Partials       38       38           
Impacted Files Coverage Δ
packages/relay/src/lib/eth.ts 64.25% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbc34c6...e0e501b. Read the comment docs.

Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@natanasow natanasow marked this pull request as ready for review July 19, 2022 08:33
Copy link
Collaborator

@ar-conmit ar-conmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@Nana-EC Nana-EC added bug Something isn't working limechain P1 labels Jul 19, 2022
@Nana-EC Nana-EC added this to In progress in Development via automation Jul 19, 2022
@Nana-EC Nana-EC added this to the 0.5.0 milestone Jul 19, 2022
@Nana-EC Nana-EC merged commit a099ac6 into main Jul 20, 2022
Development automation moved this from In progress to Done Jul 20, 2022
@Nana-EC Nana-EC deleted the 337-align-log-with-execution-apis branch July 20, 2022 05:00
Nana-EC pushed a commit that referenced this pull request Jul 21, 2022
Update log response integers to be hexadecimals

Signed-off-by: nikolay <[email protected]>
Nana-EC pushed a commit that referenced this pull request Jul 21, 2022
Update log response integers to be hexadecimals

Signed-off-by: Nikolay Atanasow <[email protected]>
Signed-off-by: Nana-EC <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working limechain P1
Projects
Development

Successfully merging this pull request may close these issues.

Align log with execution apis
6 participants